KEMBAR78
Port amax to stable ABI by samanklesaria · Pull Request #160214 · pytorch/pytorch · GitHub
Skip to content

Port amax to stable ABI #160214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Port amax to stable ABI #160214

wants to merge 11 commits into from

Conversation

@samanklesaria
Copy link
Contributor

@samanklesaria samanklesaria commented Aug 8, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160214

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7d25b60 with merge base 1f19003 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 8, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

@samanklesaria samanklesaria force-pushed the stable_amax branch 3 times, most recently from d8bbd23 to d81b440 Compare August 11, 2025 17:25
benjaminglass1
benjaminglass1 reviewed Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@benjaminglass1 benjaminglass1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than the one issue in the stable ops file.

benjaminglass1
benjaminglass1 reviewed Aug 12, 2025
View reviewed changes
@samanklesaria samanklesaria force-pushed the stable_amax branch 2 times, most recently from 1df8d73 to 93833d3 Compare August 13, 2025 18:29
@samanklesaria samanklesaria marked this pull request as ready for review August 15, 2025 15:05
mikaylagawarecki
mikaylagawarecki reviewed Aug 15, 2025
View reviewed changes
mikaylagawarecki
mikaylagawarecki reviewed Aug 15, 2025
View reviewed changes
mikaylagawarecki
mikaylagawarecki approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit, feel free to merge after when CI is green

@samanklesaria
Copy link
Contributor Author

I don't have merge access- could you merge for me?

janeyx99
janeyx99 reviewed Aug 18, 2025
View reviewed changes
janeyx99
janeyx99 reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To merge when ready, you can comment @ pytorchbot merge (no space after @ when u actually do it tho)

@samanklesaria
Copy link
Contributor Author

I added a longer explanation to the docs. Anything more it should say before I merge?

@samanklesaria samanklesaria requested a review from janeyx99 August 18, 2025 21:42
@amjames
Copy link
Collaborator

amjames commented Aug 18, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 18, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@samanklesaria @markc-614
Port amax to stable ABI (pytorch#160214)
fd5ea26 
To enable porting torchaudio to the stable ABI, we need the `amax` operation to be accessible. This PR ports the op and provides tests that it behaves correctly.

Pull Request resolved: pytorch#160214
Approved by: https://github.com/mikaylagawarecki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminglass1 benjaminglass1 benjaminglass1 left review comments

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@janeyx99 janeyx99 Awaiting requested review from janeyx99 janeyx99 is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: inductor (aoti)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@samanklesaria @amjames @pytorchmergebot @mikaylagawarecki @benjaminglass1 @janeyx99 @pytorchbot