KEMBAR78
[MPS] Sparse coalesce more dtypes to match cpu by Isalia20 · Pull Request #160254 · pytorch/pytorch · GitHub
Skip to content

[MPS] Sparse coalesce more dtypes to match cpu #160254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Sparse coalesce more dtypes to match cpu #160254

wants to merge 2 commits into from

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20 Isalia20 commented Aug 9, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160254

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5684b14 with merge base 2971231 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Aug 9, 2025
@Isalia20 Isalia20 added module: mps Related to Apple Metal Performance Shaders framework module: sparse Related to torch.sparse ciflow/mps Run MPS tests (subset of trunk) labels Aug 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2025

To add the ciflow label ciflow/mps please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Aug 9, 2025
@Isalia20 Isalia20 added the ciflow/mps Run MPS tests (subset of trunk) label Aug 9, 2025
pearu
pearu reviewed Aug 9, 2025
View reviewed changes
malfet
malfet approved these changes Aug 10, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it feels like I need to add a generic macro that would instantiate the kernel for all known dtypes

@malfet
Copy link
Contributor

malfet commented Aug 10, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@Isalia20 @markc-614
[MPS] Sparse coalesce more dtypes to match cpu (pytorch#160254)
9c1a13f 
More dtypes to match the cpu

Pull Request resolved: pytorch#160254
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pearu pearu pearu left review comments

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged module: mps Related to Apple Metal Performance Shaders framework module: sparse Related to torch.sparse open source release notes: sparse release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Isalia20 @malfet @pytorchmergebot @pearu @pytorchbot