KEMBAR78
Fix MPS autocast for ConvTranspose3d by malfet · Pull Request #160345 · pytorch/pytorch · GitHub
Skip to content

Fix MPS autocast for ConvTranspose3d #160345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix MPS autocast for ConvTranspose3d #160345

wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 11, 2025 •
edited by pytorch-bot bot
Loading

Summary

  • ensure ConvTranspose3d uses fp32 under MPS autocast
  • add MPS autocast test for ConvTranspose3d

Generated by Codex, see https://chatgpt.com/codex/tasks/task_e_689a360388288327a2cac6f55bbfc42c

Fixes #160332

cc @mcarilli @ptrblck @leslie-fang-intel @jgong5

@malfet malfet requested a review from kulinseth as a code owner August 11, 2025 18:48
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160345

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 11ada1f with merge base c8205cb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) module: amp (automated mixed precision) autocast labels Aug 11, 2025
@malfet malfet requested a review from dcci August 11, 2025 20:54
@malfet malfet added the topic: bug fixes topic category label Aug 11, 2025
@malfet malfet added the release notes: mps Release notes category label Aug 11, 2025
@malfet
Copy link
Contributor Author

malfet commented Aug 11, 2025

@pytorchbot merge -f "Lint + MPS are green, but code is AI generated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

wincent8 pushed a commit to wincent8/pytorch that referenced this pull request Aug 12, 2025
@malfet @wincent8
Fix MPS autocast for ConvTranspose3d (pytorch#160345)
9696c05 
## Summary
- ensure ConvTranspose3d uses fp32 under MPS autocast
- add MPS autocast test for ConvTranspose3d

Generated by Codex, see https://chatgpt.com/codex/tasks/task_e_689a360388288327a2cac6f55bbfc42c

Fixes pytorch#160332

Pull Request resolved: pytorch#160345
Approved by: https://github.com/dcci
samanklesaria pushed a commit to samanklesaria/pytorch that referenced this pull request Aug 12, 2025
@malfet @samanklesaria
Fix MPS autocast for ConvTranspose3d (pytorch#160345)
b354ef0 
## Summary
- ensure ConvTranspose3d uses fp32 under MPS autocast
- add MPS autocast test for ConvTranspose3d

Generated by Codex, see https://chatgpt.com/codex/tasks/task_e_689a360388288327a2cac6f55bbfc42c

Fixes pytorch#160332

Pull Request resolved: pytorch#160345
Approved by: https://github.com/dcci
@github-actions github-actions bot deleted the codex/propose-fix-for-issue-160332 branch September 11, 2025 02:11
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
Fix MPS autocast for ConvTranspose3d (pytorch#160345)
e535026 
## Summary
- ensure ConvTranspose3d uses fp32 under MPS autocast
- add MPS autocast test for ConvTranspose3d

Generated by Codex, see https://chatgpt.com/codex/tasks/task_e_689a360388288327a2cac6f55bbfc42c

Fixes pytorch#160332

Pull Request resolved: pytorch#160345
Approved by: https://github.com/dcci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcci dcci dcci approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) codex Merged module: amp (automated mixed precision) autocast release notes: mps Release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use FP32 for ConvTranspose3D when using autocast on MPS

3 participants

@malfet @pytorchmergebot @dcci