move thread-local capture mode guard to include work.isStarted #160398
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160398
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d44850a with merge base ca7315c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
aorenste
approved these changes
Aug 12, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Couldn't repro the original condition in after playing around but the change looks fine |
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 14, 2025
Per title, should fix capture errors that happen because nccl watchdog races with capture start. Pull Request resolved: #160398 Approved by: https://github.com/aorenste
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 18, 2025
Per title, should fix capture errors that happen because nccl watchdog races with capture start. Pull Request resolved: #160398 Approved by: https://github.com/aorenste
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
…ch#160398) Per title, should fix capture errors that happen because nccl watchdog races with capture start. Pull Request resolved: pytorch#160398 Approved by: https://github.com/aorenste
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ch#160398) Per title, should fix capture errors that happen because nccl watchdog races with capture start. Pull Request resolved: pytorch#160398 Approved by: https://github.com/aorenste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, should fix capture errors that happen because nccl watchdog races with capture start.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta