KEMBAR78
Fix MPS conv3d autocast bias dtype mismatch by malfet · Pull Request #160423 · pytorch/pytorch · GitHub
Skip to content

Fix MPS conv3d autocast bias dtype mismatch #160423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix MPS conv3d autocast bias dtype mismatch #160423

wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 12, 2025 •
edited
Loading

Summary

  • register conv3d with MPS autocast to ensure bias dtypes match under AMP
  • add regression test chaining two Conv3d layers on MPS autocast

Written by Codex, see https://chatgpt.com/codex/tasks/task_e_689b64192df883278648935963d2776d

cc @mcarilli @ptrblck @leslie-fang-intel @jgong5

@malfet malfet requested a review from kulinseth as a code owner August 12, 2025 16:27
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160423

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ae496fd with merge base b219ca2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) module: amp (automated mixed precision) autocast labels Aug 12, 2025
@malfet malfet requested a review from dcci August 12, 2025 20:04
@malfet malfet added the topic: bug fixes topic category label Aug 12, 2025
@malfet
Copy link
Contributor Author

malfet commented Aug 13, 2025

@pytorchbot merge -f "CI is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

chuanhaozhuge pushed a commit that referenced this pull request Aug 14, 2025
@malfet @chuanhaozhuge
Fix MPS conv3d autocast bias dtype mismatch (#160423)
2258660 
## Summary
- register conv3d with MPS autocast to ensure bias dtypes match under AMP
- add regression test chaining two Conv3d layers on MPS autocast

Written by Codex, see https://chatgpt.com/codex/tasks/task_e_689b64192df883278648935963d2776d

Pull Request resolved: #160423
Approved by: https://github.com/dcci
chuanhaozhuge pushed a commit that referenced this pull request Aug 18, 2025
@malfet @chuanhaozhuge
Fix MPS conv3d autocast bias dtype mismatch (#160423)
c303d5a 
## Summary
- register conv3d with MPS autocast to ensure bias dtypes match under AMP
- add regression test chaining two Conv3d layers on MPS autocast

Written by Codex, see https://chatgpt.com/codex/tasks/task_e_689b64192df883278648935963d2776d

Pull Request resolved: #160423
Approved by: https://github.com/dcci
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@malfet @can-gaa-hou
Fix MPS conv3d autocast bias dtype mismatch (pytorch#160423)
50eceea 
## Summary
- register conv3d with MPS autocast to ensure bias dtypes match under AMP
- add regression test chaining two Conv3d layers on MPS autocast

Written by Codex, see https://chatgpt.com/codex/tasks/task_e_689b64192df883278648935963d2776d

Pull Request resolved: pytorch#160423
Approved by: https://github.com/dcci
@github-actions github-actions bot deleted the codex/fix-issue-160415-in-pytorch branch September 13, 2025 02:05
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
Fix MPS conv3d autocast bias dtype mismatch (pytorch#160423)
37f9ecc 
## Summary
- register conv3d with MPS autocast to ensure bias dtypes match under AMP
- add regression test chaining two Conv3d layers on MPS autocast

Written by Codex, see https://chatgpt.com/codex/tasks/task_e_689b64192df883278648935963d2776d

Pull Request resolved: pytorch#160423
Approved by: https://github.com/dcci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcci dcci dcci approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) codex Merged module: amp (automated mixed precision) autocast topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @dcci