KEMBAR78
Fix error message for fsdp_pre_all_gather by ad8e · Pull Request #160817 · pytorch/pytorch · GitHub
Skip to content

Fix error message for fsdp_pre_all_gather #160817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix error message for fsdp_pre_all_gather #160817

wants to merge 1 commit into from

Conversation

@ad8e
Copy link
Contributor

@ad8e ad8e commented Aug 16, 2025 •
edited by pytorch-bot bot
Loading

See:

pytorch/test/distributed/_composable/fsdp/test_fully_shard_extensions.py

Lines 97 to 104 in 20e4049

def fsdp_pre_all_gather(
self,
mesh: DeviceMesh,
outer_size: torch.Size,
outer_stride: tuple[int, ...],
module: nn.Module,
mp_policy: MixedPrecisionPolicy,
) -> tuple[tuple[torch.Tensor, ...], Any]:

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160817

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d7052e7 with merge base 2603e40 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Aug 16, 2025
@zou3519 zou3519 requested review from H-Huang and wconstab August 19, 2025 15:19
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 19, 2025
@H-Huang
Copy link
Member

H-Huang commented Aug 19, 2025

cc @weifengpy @mori360

@H-Huang H-Huang requested review from mori360 and weifengpy August 19, 2025 15:30
@H-Huang
Copy link
Member

H-Huang commented Aug 19, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 19, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@H-Huang
Copy link
Member

H-Huang commented Aug 20, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ad8e ad8e deleted the patch-3 branch August 20, 2025 17:45
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@ad8e @markc-614
Fix error message for fsdp_pre_all_gather (pytorch#160817)
7ce8dd5 
See: https://github.com/pytorch/pytorch/blob/20e40492b046b9287726d3ec656117e4dc38f0e2/test/distributed/_composable/fsdp/test_fully_shard_extensions.py#L97-L104

Pull Request resolved: pytorch#160817
Approved by: https://github.com/weifengpy, https://github.com/H-Huang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H-Huang H-Huang H-Huang approved these changes

@weifengpy weifengpy weifengpy approved these changes

@wconstab wconstab Awaiting requested review from wconstab

@mori360 mori360 Awaiting requested review from mori360

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (fsdp) release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ad8e @H-Huang @pytorchmergebot @weifengpy @zou3519 @pytorchbot