Replace use of ConstantLike with with ConstantOfShape #16095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
houseroad
reviewed
Jan 17, 2019
|
@houseroad - There's some failure in test run and I am not sure I understand why. Could you please take a look and advise. |
|
Yes, I am working on that |
spandantiwari
force-pushed
the
spandantiwari/replace_with_constantofshape
branch
from
c28ac61 to
1bfa277
Compare
houseroad
force-pushed
the
spandantiwari/replace_with_constantofshape
branch
from
1bfa277 to
3d0f6e3
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 19, 2019
houseroad
force-pushed
the
spandantiwari/replace_with_constantofshape
branch
from
3d0f6e3 to
d18bf90
Compare
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jan 20, 2019
Summary: Submitting this PR as an update to existing PR (pytorch/pytorch#15938) on houseroad 's request. This PR replaces the use of ONNX op `ConstantLike` with `ConstantOfShape` in the ONNX exporter. In addition to removing the call sites in `symbolic.py`, it also replace the call site in `peephole.cpp`. Pull Request resolved: pytorch/pytorch#16095 Differential Revision: D13745723 Pulled By: houseroad fbshipit-source-id: e2a5f534f01adf199df9e27544f7afcfa540e1f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this PR as an update to existing PR (#15938) on @houseroad 's request.
This PR replaces the use of ONNX op
ConstantLikewithConstantOfShapein the ONNX exporter. In addition to removing the call sites insymbolic.py, it also replace the call site inpeephole.cpp.