[pytorch] Faster and safer lambda expression capture in has_integral_tensor()
#161042
Conversation
…_tensor()` Summary: Because `includeBool` is already a small value type (i.e., `bool`, 1 byte) that's passed by value to the function. Capturing by reference (4 or 8 bytes depending on the system) is unnecessary and could potentially lead to dangling reference issues if the lambda outlives the original variable. Capturing by value is more efficient for small types and safer. Test Plan: OSS CI & tests Rollback Plan: Differential Revision: D80595698
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @tsunghsienlee, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161042
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c2e9e7d with merge base a9fabeb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D80595698 |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…_tensor()` (pytorch#161042) Summary: Because `includeBool` is already a small value type (i.e., `bool`, 1 byte) that's passed by value to the function. Capturing by reference (4 or 8 bytes depending on the system) is unnecessary and could potentially lead to dangling reference issues if the lambda outlives the original variable. Capturing by value is more efficient for small types and safer. Test Plan: OSS CI & tests Rollback Plan: Differential Revision: D80595698 Pull Request resolved: pytorch#161042 Approved by: https://github.com/Skylion007
4 participants
Summary: Because
includeBoolis already a small value type (i.e.,bool, 1 byte) that's passed by value to the function. Capturing by reference (4 or 8 bytes depending on the system) is unnecessary and could potentially lead to dangling reference issues if the lambda outlives the original variable. Capturing by value is more efficient for small types and safer.Test Plan:
OSS CI & tests
Rollback Plan:
Differential Revision: D80595698