KEMBAR78
Clear custom autograd Function ctx.to_save earlier by soulitzer · Pull Request #161171 · pytorch/pytorch · GitHub
Skip to content

Clear custom autograd Function ctx.to_save earlier #161171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Clear custom autograd Function ctx.to_save earlier #161171

wants to merge 4 commits into from

Conversation

@soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Aug 21, 2025 •
edited by pytorch-bot bot
Loading

@soulitzer soulitzer requested a review from albanD as a code owner August 21, 2025 16:59
@soulitzer soulitzer mentioned this pull request Aug 21, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161171

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 1 Pending

As of commit 7113cb6 with merge base 6737e2c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

soulitzer added a commit that referenced this pull request Aug 21, 2025
@soulitzer
Clear custom autograd Function ctx.to_save earlier
f2d7594 
ghstack-source-id: 172a930
Pull Request resolved: #161171
soulitzer added a commit that referenced this pull request Aug 21, 2025
@soulitzer
Clear custom autograd Function ctx.to_save earlier
f454cfc 
ghstack-source-id: 87fd65b
Pull Request resolved: #161171
albanD
albanD approved these changes Aug 29, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this doesn't help if the user throws an error inside their forward after they saved for backward. But I guess it's narrow enough that it doesn't matter.

@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@soulitzer soulitzer added the release notes: autograd release notes category label Aug 29, 2025
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 4 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 7 checks: Check mergeability of ghstack PR / ghstack-mergeability-check, pull / linux-jammy-py3-clang12-mobile-build / build, pull / linux-jammy-py3.9-clang12 / test (default, 4, 5, lf.linux.4xlarge), pull / linux-jammy-py3.9-gcc11 / test (default, 5, 5, lf.linux.2xlarge), pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable), pull / linux-jammy-cuda12.8-py3.10-gcc11-test / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu), pull / linux-jammy-cuda12.8-py3.10-gcc11-sm89 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Check Labels / Check labels

Details for Dev Infra team Raised by workflow job

@soulitzer
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@soulitzer
Update
1a631a5 
[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Sep 1, 2025
@soulitzer
Clear custom autograd Function ctx.to_save earlier
21fd980 
ghstack-source-id: dab41dc
Pull Request resolved: #161171
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/soulitzer/377/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/161171)

@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 4, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

soulitzer added a commit that referenced this pull request Sep 1, 2025
@soulitzer
Clear custom autograd Function ctx.to_save earlier
ec3a86f 
ghstack-source-id: c77ed6f
Pull Request resolved: #161171
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@soulitzer @markc-614
Clear custom autograd Function ctx.to_save earlier (pytorch#161171)
ffaac7d 
Fixes pytorch#161186

Pull Request resolved: pytorch#161171
Approved by: https://github.com/albanD
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@soulitzer @mansiag05
Clear custom autograd Function ctx.to_save earlier (pytorch#161171)
3583fde 
Fixes pytorch#161186

Pull Request resolved: pytorch#161171
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the gh/soulitzer/377/head branch October 3, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: autograd release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soulitzer @pytorchmergebot @albanD