[tgif] fix getattr_recursive with ModuleList #161204
Conversation
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @liangwang, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161204
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a33347b with merge base 74280d0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D80503985 |
liangwang
force-pushed
the
export-D80503985
branch
from
e29b123 to
18e0665
Compare
Summary: This change updates `getattr_recursive` to handle qualnames with ModuleList that contain digit indices, for example, `op_instances.1.value_model.feature_weights` Test Plan: TBA Rollback Plan: Reviewed By: jiayisuse Differential Revision: D80503985
|
This pull request was exported from Phabricator. Differential Revision: D80503985 |
Summary: Pull Request resolved: pytorch#161204 This change updates `getattr_recursive` to handle qualnames with ModuleList that contain digit indices, for example, `op_instances.1.value_model.feature_weights` Test Plan: TBA Rollback Plan: Reviewed By: jiayisuse Differential Revision: D80503985
liangwang
force-pushed
the
export-D80503985
branch
from
18e0665 to
996d3e2
Compare
|
/easycla |
liangwang
force-pushed
the
export-D80503985
branch
from
996d3e2 to
1c57cec
Compare
Summary: This change updates `getattr_recursive` to handle qualnames with ModuleList that contain digit indices, for example, `op_instances.1.value_model.feature_weights` Test Plan: TBA Rollback Plan: Reviewed By: jiayisuse Differential Revision: D80503985
Summary: This change updates `getattr_recursive` to handle qualnames with ModuleList that contain digit indices, for example, `op_instances.1.value_model.feature_weights` Test Plan: TBA Rollback Plan: Reviewed By: jiayisuse Differential Revision: D80503985
liangwang
force-pushed
the
export-D80503985
branch
from
1c57cec to
3804977
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80503985 |
Summary: Pull Request resolved: pytorch#161204 This change updates `getattr_recursive` to handle qualnames with ModuleList that contain digit indices, for example, `op_instances.1.value_model.feature_weights` Test Plan: TBA Rollback Plan: Reviewed By: jiayisuse Differential Revision: D80503985
liangwang
force-pushed
the
export-D80503985
branch
from
3804977 to
ccbcf6b
Compare
Summary: Pull Request resolved: pytorch#161204 This change updates `getattr_recursive` to handle qualnames with ModuleList that contain digit indices, for example, `op_instances.1.value_model.feature_weights` Test Plan: TBA Rollback Plan: Reviewed By: jiayisuse Differential Revision: D80503985
|
This pull request was exported from Phabricator. Differential Revision: D80503985 |
liangwang
force-pushed
the
export-D80503985
branch
from
ccbcf6b to
a33347b
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: This change updates `getattr_recursive` to handle qualnames with ModuleList that contain digit indices, for example, `op_instances.1.value_model.feature_weights` Test Plan: TBA Rollback Plan: Reviewed By: jiayisuse Differential Revision: D80503985 Pull Request resolved: pytorch#161204 Approved by: https://github.com/jiayisuse
4 participants
Summary: This change updates
getattr_recursiveto handle qualnames with ModuleList that contain digit indices, for example,op_instances.1.value_model.feature_weightsTest Plan:
TBA
Rollback Plan:
Reviewed By: jiayisuse
Differential Revision: D80503985
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv