`__eq__` didn't compare lists of DTensorSpec, but `__hash__` did (and
it looks like attention was paid to hash, so I made comparison follow
suit).

ghstack-source-id: 33571f3
Pull Request resolved: #161231

…h__` and `__eq__` (#161234)

The performance cost of `dict` lookups keyed by `OpSchema` is a
significant minority of DTensor overhead. With this change we shave a
net ~1% off the total running time of the benchmark from #160580, as
measured by using cProfile and comparing cumulative time spent in
propagate + OpSchema's `__post_init__`. (`__post_init__` grew from
2.5% to 6.4% (+3.9%) and propagate shrank from 12.5% to 7.8% (-4.7%)).

Pull Request resolved: #161234
Approved by: https://github.com/wconstab
ghstack dependencies: #161231

`self is other` means the same thing as `id(self) == id(other)`, but it's one operator instead of 3.

Pull Request resolved: #161235
Approved by: https://github.com/wconstab, https://github.com/zpcore, https://github.com/fduwjj
ghstack dependencies: #161231, #161234

…161240)

get_write_alias() call count reduction explained briefly in code comment.

We don't need to check write_aliases against None in the final outs_to_return calculation because we just did that check.
Pull Request resolved: #161240
Approved by: https://github.com/wconstab
ghstack dependencies: #161231, #161234, #161235

…ly_alias_match (#161284)

Containers are truthy iff they're non-empty.
Pull Request resolved: #161284
Approved by: https://github.com/Skylion007, https://github.com/wconstab
ghstack dependencies: #161231, #161234, #161235, #161240

Drives down the overhead of return_and_correct_storage_aliasing slightly. Hopefully you'll agree it doesn't compromise readability.
Pull Request resolved: #161285
Approved by: https://github.com/wconstab
ghstack dependencies: #161231, #161234, #161235, #161240, #161284

`__eq__` didn't compare lists of DTensorSpec, but `__hash__` did (and
it looks like attention was paid to hash, so I made comparison follow
suit).

Pull Request resolved: pytorch#161231
Approved by: https://github.com/wconstab, https://github.com/XilunWu, https://github.com/zpcore

…h__` and `__eq__` (pytorch#161234)

The performance cost of `dict` lookups keyed by `OpSchema` is a
significant minority of DTensor overhead. With this change we shave a
net ~1% off the total running time of the benchmark from pytorch#160580, as
measured by using cProfile and comparing cumulative time spent in
propagate + OpSchema's `__post_init__`. (`__post_init__` grew from
2.5% to 6.4% (+3.9%) and propagate shrank from 12.5% to 7.8% (-4.7%)).

Pull Request resolved: pytorch#161234
Approved by: https://github.com/wconstab
ghstack dependencies: pytorch#161231

`self is other` means the same thing as `id(self) == id(other)`, but it's one operator instead of 3.

Pull Request resolved: pytorch#161235
Approved by: https://github.com/wconstab, https://github.com/zpcore, https://github.com/fduwjj
ghstack dependencies: pytorch#161231, pytorch#161234

…ytorch#161240)

get_write_alias() call count reduction explained briefly in code comment.

We don't need to check write_aliases against None in the final outs_to_return calculation because we just did that check.
Pull Request resolved: pytorch#161240
Approved by: https://github.com/wconstab
ghstack dependencies: pytorch#161231, pytorch#161234, pytorch#161235

…ly_alias_match (pytorch#161284)

Containers are truthy iff they're non-empty.
Pull Request resolved: pytorch#161284
Approved by: https://github.com/Skylion007, https://github.com/wconstab
ghstack dependencies: pytorch#161231, pytorch#161234, pytorch#161235, pytorch#161240

…#161285)

Drives down the overhead of return_and_correct_storage_aliasing slightly. Hopefully you'll agree it doesn't compromise readability.
Pull Request resolved: pytorch#161285
Approved by: https://github.com/wconstab
ghstack dependencies: pytorch#161231, pytorch#161234, pytorch#161235, pytorch#161240, pytorch#161284