[dtensor] support local_map as a decorator #161353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161353
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit 3a92a02 with merge base dbef606 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
This was referenced Aug 26, 2025
zpcore
approved these changes
Aug 26, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable), trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m1-14) Details for Dev Infra teamRaised by workflow job |
|
Starting merge as part of PR stack under #161479 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 28, 2025
Adds the pre-dispatch handling for the AC hop. This lets the HOP pre-dispatch export without actually pre-dispatch tracing into it,. However, this is not sufficient to support AC in export: - because the HOP body will still be in torch IR, so it will fail export verifiers - the exported module also can't be ran in eager because the AC HOP relies on partitioner to embed RNG state saving/restoring So it must be lowered by AOT Autograd into post-dispatch first before being executed, It suffices for my purposes though. If users had checkpoint API use in their exported model, the behavior goes from silently incorrect to now be validation error. Pull Request resolved: #161479 Approved by: https://github.com/ydwu4 ghstack dependencies: #161353
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
And extract it out as a convenience function for dynamo to wrap Pull Request resolved: pytorch#161353 Approved by: https://github.com/zpcore
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Adds the pre-dispatch handling for the AC hop. This lets the HOP pre-dispatch export without actually pre-dispatch tracing into it,. However, this is not sufficient to support AC in export: - because the HOP body will still be in torch IR, so it will fail export verifiers - the exported module also can't be ran in eager because the AC HOP relies on partitioner to embed RNG state saving/restoring So it must be lowered by AOT Autograd into post-dispatch first before being executed, It suffices for my purposes though. If users had checkpoint API use in their exported model, the behavior goes from silently incorrect to now be validation error. Pull Request resolved: pytorch#161479 Approved by: https://github.com/ydwu4 ghstack dependencies: pytorch#161353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
And extract it out as a convenience function for dynamo to wrap
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta