KEMBAR78
[fx] Add is_fx_symbolic_tracing flag by angelayi · Pull Request #161385 · pytorch/pytorch · GitHub
Skip to content

[fx] Add is_fx_symbolic_tracing flag #161385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[fx] Add is_fx_symbolic_tracing flag #161385

wants to merge 1 commit into from

Conversation

@angelayi
Copy link
Contributor

@angelayi angelayi commented Aug 25, 2025 •
edited by pytorch-bot bot
Loading

@angelayi angelayi requested a review from pianpwk August 25, 2025 03:40
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161385

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 572645d with merge base 7f201ba (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Aug 25, 2025
@angelayi angelayi marked this pull request as ready for review August 25, 2025 16:56
@angelayi angelayi force-pushed the angelayi/is_symbolic_tracing branch from 8c209af to 02cc04f Compare August 26, 2025 03:25
@angelayi angelayi force-pushed the angelayi/is_symbolic_tracing branch from 02cc04f to e09ab9c Compare August 26, 2025 03:29
@angelayi angelayi force-pushed the angelayi/is_symbolic_tracing branch from e09ab9c to 572645d Compare August 26, 2025 03:32
@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 26, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@angelayi @markc-614
[fx] Add is_fx_symbolic_tracing flag (pytorch#161385)
5241826 
Fixes pytorch#135276

Pull Request resolved: pytorch#161385
Approved by: https://github.com/pianpwk
@github-actions github-actions bot deleted the angelayi/is_symbolic_tracing branch September 26, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pianpwk pianpwk pianpwk approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged module: dynamo release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[export] is_fx_tracing evaluates to true when exporting non-strict

4 participants

@angelayi @pytorchmergebot @pianpwk @facebook-github-bot