KEMBAR78
Skip const folding with symbolic expression by arui-meta · Pull Request #161437 · pytorch/pytorch · GitHub
Skip to content

Skip const folding with symbolic expression #161437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Skip const folding with symbolic expression #161437

wants to merge 1 commit into from

Conversation

@arui-meta
Copy link
Contributor

@arui-meta arui-meta commented Aug 25, 2025 •
edited by pytorch-bot bot
Loading

Summary: When performing constant folding, we must skip over operators that have symbolic fill_value.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161437

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 46627fd with merge base 3d40642 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Aug 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

@StellarrZ StellarrZ self-requested a review August 25, 2025 20:25
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 25, 2025
arui-meta added a commit to arui-meta/pytorch that referenced this pull request Aug 25, 2025
@arui-meta @facebook-github-bot
Skip const folding with symbolic expression (pytorch#161437)
2eea1c9 
Summary:

When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

arui-meta added a commit to arui-meta/pytorch that referenced this pull request Aug 26, 2025
@arui-meta @facebook-github-bot
Skip const folding with symbolic expression (pytorch#161437)
7c3fa74 
Summary:

When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

arui-meta added a commit to arui-meta/pytorch that referenced this pull request Aug 26, 2025
@arui-meta @facebook-github-bot
Skip const folding with symbolic expression (pytorch#161437)
339788c 
Summary:

When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

arui-meta added a commit to arui-meta/pytorch that referenced this pull request Aug 26, 2025
@arui-meta @facebook-github-bot
Skip const folding with symbolic expression (pytorch#161437)
22d7477 
Summary:

When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

arui-meta added a commit to arui-meta/pytorch that referenced this pull request Aug 26, 2025
@arui-meta @facebook-github-bot
Skip const folding with symbolic expression (pytorch#161437)
4495ca0 
Summary:

When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

arui-meta added a commit to arui-meta/pytorch that referenced this pull request Aug 26, 2025
@arui-meta @facebook-github-bot
Skip const folding with symbolic expression (pytorch#161437)
dd4b8ca 
Summary:

When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

@arui-meta @facebook-github-bot
Skip const folding with symbolic expression (pytorch#161437)
46627fd 
Summary:

When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80965936

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@arui-meta @markc-614
Skip const folding with symbolic expression (pytorch#161437)
0a65e87 
Summary: When performing constant folding, we must skip over operators that have symbolic `fill_value`.

Test Plan:
CI

Rollback Plan:

Reviewed By: kalpit-meta-1

Differential Revision: D80965936

Pull Request resolved: pytorch#161437
Approved by: https://github.com/StellarrZ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StellarrZ StellarrZ StellarrZ approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported fx Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arui-meta @facebook-github-bot @pytorchmergebot @StellarrZ