KEMBAR78
Add new_zeros dtype variant to the shim and as a stable op by janeyx99 · Pull Request #161597 · pytorch/pytorch · GitHub
Skip to content

Add new_zeros dtype variant to the shim and as a stable op #161597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add new_zeros dtype variant to the shim and as a stable op #161597

wants to merge 1 commit into from

Conversation

@janeyx99
Copy link
Contributor

In case we want this before 2.9

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161597

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 41f17e6 with merge base 624bc36 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

@mikaylagawarecki mikaylagawarecki changed the title Add new_empty dtype variant to the shim and as a stable op Add new_zeros dtype variant to the shim and as a stable op Aug 27, 2025
@mikaylagawarecki
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased new_zeros_dtype onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout new_zeros_dtype && git pull --rebase)

@mikaylagawarecki mikaylagawarecki added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 27, 2025
@mikaylagawarecki
Copy link
Contributor

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased new_zeros_dtype onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout new_zeros_dtype && git pull --rebase)

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@mikaylagawarecki mikaylagawarecki added the topic: new features topic category label Aug 28, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@janeyx99 @markc-614
Add new_zeros dtype variant to the shim and as a stable op (pytorch#1…
9fcf58c 
…61597)

In case we want this before 2.9
Pull Request resolved: pytorch#161597
Approved by: https://github.com/mikaylagawarecki
@github-actions github-actions bot deleted the new_zeros_dtype branch September 28, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: inductor (aoti) topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janeyx99 @mikaylagawarecki @pytorchmergebot