KEMBAR78
Error when TORCH_STABLE_ONLY is defined in TensorBase.h by mikaylagawarecki · Pull Request #161658 · pytorch/pytorch · GitHub
Skip to content

Error when TORCH_STABLE_ONLY is defined in TensorBase.h #161658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Error when TORCH_STABLE_ONLY is defined in TensorBase.h #161658

wants to merge 8 commits into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 27, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161658

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 37bb0a6 with merge base c239008 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
319f06f 
ghstack-source-id: b6a2c35
Pull Request resolved: #161658
mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
8dc77eb 
ghstack-source-id: d18aa42
Pull Request resolved: #161658
mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
e463aea 
ghstack-source-id: a116bb5
Pull Request resolved: #161658
albanD
albanD approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on adding a comment, Sounds like a good basic solution!

@mikaylagawarecki mikaylagawarecki mentioned this pull request Aug 27, 2025
Open
mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
9560cf7 
ghstack-source-id: 6f9799c
Pull Request resolved: #161658
mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
f5048e0 
ghstack-source-id: ef51836
Pull Request resolved: #161658
@mikaylagawarecki mikaylagawarecki added module: build Build system issues release notes: build release notes category topic: not user facing topic category and removed module: build Build system issues labels Aug 27, 2025
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review August 27, 2025 21:43
mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
2a8e00c 
ghstack-source-id: b06f395
Pull Request resolved: #161658
mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
f26c73a 
ghstack-source-id: fa219c7
Pull Request resolved: #161658
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

mikaylagawarecki added a commit that referenced this pull request Aug 27, 2025
@mikaylagawarecki
Error when TORCH_STABLE_ONLY is defined in TensorBase.h
2e5d7eb 
ghstack-source-id: a2b05c2
Pull Request resolved: #161658
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@mikaylagawarecki @markc-614
Error when TORCH_STABLE_ONLY is defined in TensorBase.h (pytorch#161658)
346b28e 
Pull Request resolved: pytorch#161658
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the gh/mikaylagawarecki/338/head branch September 28, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaylagawarecki @pytorchmergebot @albanD