KEMBAR78
Rename propagate_tensor_meta to make private again by azahed98 · Pull Request #161744 · pytorch/pytorch · GitHub
Skip to content

Rename propagate_tensor_meta to make private again #161744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rename propagate_tensor_meta to make private again #161744

wants to merge 3 commits into from

Conversation

@azahed98
Copy link
Contributor

@azahed98 azahed98 commented Aug 28, 2025 •
edited by pytorch-bot bot
Loading

Rename the wrapper propagate_tensor_meta added in #161334 to make it clearly private, and rename the existing LRU function to accommodate.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim @dcci

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161744

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 563b96c with merge base 1288c6d (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Aug 28, 2025
@azahed98 azahed98 added the release notes: distributed (dtensor) release notes category label Aug 28, 2025
@azahed98 azahed98 requested a review from bdhirsh August 29, 2025 04:50
@azahed98 azahed98 mentioned this pull request Aug 29, 2025
Closed
@azahed98
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@azahed98
Copy link
Contributor Author

azahed98 commented Sep 2, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@azahed98
Copy link
Contributor Author

azahed98 commented Sep 2, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/prive_prop_tensor_meta onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix/prive_prop_tensor_meta && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix/prive_prop_tensor_meta branch from 6a15dbf to d23a246 Compare September 2, 2025 21:12
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Could not find commit that was pushed before comment 3246800942

Details for Dev Infra team Raised by workflow job

@azahed98 azahed98 force-pushed the fix/prive_prop_tensor_meta branch from d23a246 to b5b2698 Compare September 3, 2025 18:15
@azahed98
Copy link
Contributor Author

azahed98 commented Sep 3, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@azahed98
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.gfx942.4)

Details for Dev Infra team Raised by workflow job

@azahed98 azahed98 force-pushed the fix/prive_prop_tensor_meta branch from 242ceb0 to 46590a7 Compare September 15, 2025 17:53
@azahed98
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@azahed98 @markc-614
Rename propagate_tensor_meta to make private again (pytorch#161744)
357daa8 
Rename the wrapper `propagate_tensor_meta` added in pytorch#161334 to make it clearly private, and rename the existing LRU function to accommodate.

Pull Request resolved: pytorch#161744
Approved by: https://github.com/bdhirsh
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "Rename propagate_tensor_meta to make private again (pytorch#1…
0227ebe 
…61744)"

This reverts commit 734ce8e.

Reverted pytorch#161744 on behalf of https://github.com/jeanschmidt due to seems to break internal tests, see D81657000 for more details ([comment](pytorch#161744 (comment)))
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@azahed98 @mansiag05
Rename propagate_tensor_meta to make private again (pytorch#161744)
35393f1 
Rename the wrapper `propagate_tensor_meta` added in pytorch#161334 to make it clearly private, and rename the existing LRU function to accommodate.

Pull Request resolved: pytorch#161744
Approved by: https://github.com/bdhirsh
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @mansiag05
Revert "Rename propagate_tensor_meta to make private again (pytorch#1…
fb4adcd 
…61744)"

This reverts commit 734ce8e.

Reverted pytorch#161744 on behalf of https://github.com/jeanschmidt due to seems to break internal tests, see D81657000 for more details ([comment](pytorch#161744 (comment)))
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @cleonard530
Revert "Rename propagate_tensor_meta to make private again (pytorch#1…
5220857 
…61744)"

This reverts commit 734ce8e.

Reverted pytorch#161744 on behalf of https://github.com/jeanschmidt due to seems to break internal tests, see D81657000 for more details ([comment](pytorch#161744 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@azahed98 @dsashidh
Rename propagate_tensor_meta to make private again (pytorch#161744)
937d17c 
Rename the wrapper `propagate_tensor_meta` added in pytorch#161334 to make it clearly private, and rename the existing LRU function to accommodate.

Pull Request resolved: pytorch#161744
Approved by: https://github.com/bdhirsh
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@pytorchmergebot @dsashidh
Revert "Rename propagate_tensor_meta to make private again (pytorch#1…
9b60598 
…61744)"

This reverts commit 734ce8e.

Reverted pytorch#161744 on behalf of https://github.com/jeanschmidt due to seems to break internal tests, see D81657000 for more details ([comment](pytorch#161744 (comment)))
@azahed98 azahed98 force-pushed the fix/prive_prop_tensor_meta branch from 46590a7 to 027bebe Compare September 30, 2025 20:42
@azahed98
Copy link
Contributor Author

azahed98 commented Oct 1, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/prive_prop_tensor_meta onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix/prive_prop_tensor_meta && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix/prive_prop_tensor_meta branch from 027bebe to 563b96c Compare October 1, 2025 21:31
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (dtensor) release notes category Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azahed98 @pytorchmergebot @jeanschmidt @bdhirsh