kill allow_complex_guards_as_runtime_asserts #161794
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avikchaudhuri
requested review from
angelayi,
bobrenjc93,
laithsakka,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161794
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 87fec9d with merge base 71992dd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D81334984 |
zhxchen17
approved these changes
Aug 29, 2025
avikchaudhuri
added
the
suppress-bc-linter
avikchaudhuri
force-pushed
the
export-D81334984
branch
from
ea59544 to
ae4915d
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Summary: [reland] Since `allow_complex_guards_as_runtime_asserts` is now sync'd with `prefer_deferred_runtime_asserts_over_guards`, we can kill the former (especially since it was a export-only concept). Test Plan: updated tests Rollback Plan: Reviewed By: zhxchen17 Differential Revision: D81334984
|
This pull request was exported from Phabricator. Differential Revision: D81334984 |
avikchaudhuri
force-pushed
the
export-D81334984
branch
from
ae4915d to
e89f01f
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: pytorch#161794 [reland] Since `allow_complex_guards_as_runtime_asserts` is now sync'd with `prefer_deferred_runtime_asserts_over_guards`, we can kill the former (especially since it was a export-only concept). Test Plan: updated tests Rollback Plan: Reviewed By: zhxchen17 Differential Revision: D81334984
Summary: Pull Request resolved: pytorch#161794 [reland] Since `allow_complex_guards_as_runtime_asserts` is now sync'd with `prefer_deferred_runtime_asserts_over_guards`, we can kill the former (especially since it was a export-only concept). Test Plan: updated tests Rollback Plan: Reviewed By: zhxchen17 Differential Revision: D81334984
|
This pull request was exported from Phabricator. Differential Revision: D81334984 |
avikchaudhuri
force-pushed
the
export-D81334984
branch
from
e89f01f to
87fec9d
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Summary: [reland] Since `allow_complex_guards_as_runtime_asserts` is now sync'd with `prefer_deferred_runtime_asserts_over_guards`, we can kill the former (especially since it was a export-only concept). Test Plan: updated tests Rollback Plan: Differential Revision: D81334984 Pull Request resolved: pytorch#161794 Approved by: https://github.com/zhxchen17
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Summary: [reland] Since `allow_complex_guards_as_runtime_asserts` is now sync'd with `prefer_deferred_runtime_asserts_over_guards`, we can kill the former (especially since it was a export-only concept). Test Plan: updated tests Rollback Plan: Differential Revision: D81334984 Pull Request resolved: pytorch#161794 Approved by: https://github.com/zhxchen17
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Summary: [reland] Since `allow_complex_guards_as_runtime_asserts` is now sync'd with `prefer_deferred_runtime_asserts_over_guards`, we can kill the former (especially since it was a export-only concept). Test Plan: updated tests Rollback Plan: Differential Revision: D81334984 Pull Request resolved: pytorch#161794 Approved by: https://github.com/zhxchen17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[reland]
Since
allow_complex_guards_as_runtime_assertsis now sync'd withprefer_deferred_runtime_asserts_over_guards, we can kill the former (especially since it was a export-only concept).Test Plan:
updated tests
Rollback Plan:
Differential Revision: D81334984
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela