KEMBAR78
[AOTI] Fix a bug from load_constants by hl475 · Pull Request #161887 · pytorch/pytorch · GitHub
Skip to content

[AOTI] Fix a bug from load_constants #161887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[AOTI] Fix a bug from load_constants #161887

wants to merge 1 commit into from

Conversation

@hl475
Copy link
Contributor

@hl475 hl475 commented Sep 1, 2025

Summary:
we have

std::vector<size_t> constants_internal_offset(
        num_constants - num_folded_constants);

but the for loop does not consider it

for (size_t i = 0; i < num_constants; i++) {
...
constants_internal_offset[i]
...

even in the for loop, it does

bool from_folded = this->constant_from_folded(i);
      if (from_folded) {
        continue;
      }

but i could still be wrong

Rollback Plan:

Differential Revision: D81425007

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161887

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit f9e740b with merge base 90f50f7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81425007

hl475 added a commit to hl475/pytorch that referenced this pull request Sep 2, 2025
@hl475 @facebook-github-bot
[AOTI] Fix a bug from load_constants (pytorch#161887)
5f5b8fa 
Summary:

we have 
```
std::vector<size_t> constants_internal_offset(
        num_constants - num_folded_constants);
```

but the for loop does not consider it
```
for (size_t i = 0; i < num_constants; i++) {
...
constants_internal_offset[i]
...
```
even in the for loop, it does
```
bool from_folded = this->constant_from_folded(i);
      if (from_folded) {
        continue;
      }
```
but `i` could still be wrong

Differential Revision: D81425007
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81425007

@hl475 hl475 changed the title [wip] do not review [AOTI] Fix a bug from load_constants Sep 2, 2025
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 2, 2025
@hl475 @facebook-github-bot
[AOTI] Fix a bug from load_constants (pytorch#161887)
f9e740b 
Summary:

we have 
```
std::vector<size_t> constants_internal_offset(
        num_constants - num_folded_constants);
```

but the for loop does not consider it
```
for (size_t i = 0; i < num_constants; i++) {
...
constants_internal_offset[i]
...
```
even in the for loop, it does
```
bool from_folded = this->constant_from_folded(i);
      if (from_folded) {
        continue;
      }
```
but `i` could still be wrong

Reviewed By: angelayi

Differential Revision: D81425007
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81425007

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Sep 11, 2025
Open
Open
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@hl475 @markc-614
[AOTI] Fix a bug from load_constants (pytorch#161887)
f8dc4a2 
Summary:
we have
```
std::vector<size_t> constants_internal_offset(
        num_constants - num_folded_constants);
```

but the for loop does not consider it
```
for (size_t i = 0; i < num_constants; i++) {
...
constants_internal_offset[i]
...
```
even in the for loop, it does
```
bool from_folded = this->constant_from_folded(i);
      if (from_folded) {
        continue;
      }
```
but `i` could still be wrong

Rollback Plan:

Differential Revision: D81425007

Pull Request resolved: pytorch#161887
Approved by: https://github.com/angelayi
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@hl475 @mansiag05
[AOTI] Fix a bug from load_constants (pytorch#161887)
f306f05 
Summary:
we have
```
std::vector<size_t> constants_internal_offset(
        num_constants - num_folded_constants);
```

but the for loop does not consider it
```
for (size_t i = 0; i < num_constants; i++) {
...
constants_internal_offset[i]
...
```
even in the for loop, it does
```
bool from_folded = this->constant_from_folded(i);
      if (from_folded) {
        continue;
      }
```
but `i` could still be wrong

Rollback Plan:

Differential Revision: D81425007

Pull Request resolved: pytorch#161887
Approved by: https://github.com/angelayi
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@hl475 @dsashidh
[AOTI] Fix a bug from load_constants (pytorch#161887)
f8b6339 
Summary:
we have
```
std::vector<size_t> constants_internal_offset(
        num_constants - num_folded_constants);
```

but the for loop does not consider it
```
for (size_t i = 0; i < num_constants; i++) {
...
constants_internal_offset[i]
...
```
even in the for loop, it does
```
bool from_folded = this->constant_from_folded(i);
      if (from_folded) {
        continue;
      }
```
but `i` could still be wrong

Rollback Plan:

Differential Revision: D81425007

Pull Request resolved: pytorch#161887
Approved by: https://github.com/angelayi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@yushangdi yushangdi Awaiting requested review from yushangdi

@houseroad houseroad Awaiting requested review from houseroad

@muchulee8 muchulee8 Awaiting requested review from muchulee8

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: inductor (aoti)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hl475 @facebook-github-bot @pytorchmergebot @angelayi