KEMBAR78
[MPS] Add `igamma/igammac` ops by kurtamohler · Pull Request #161927 · pytorch/pytorch · GitHub
Skip to content

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Sep 1, 2025

[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Sep 1, 2025
ghstack-source-id: 6127c65
Pull-Request: #161927
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161927

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit b84fff5 with merge base 5561e45 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Sep 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

return expm1f(a);
}

// NOTE: The following code was ported directly from the CUDA implementation in
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could make the CUDA and Metal impls share the same code. It would have to be peppered with a lot of ifdefs, but maybe it would be worth doing?

[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Sep 1, 2025
ghstack-source-id: 82ec4ba
Pull-Request: #161927
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Sep 2, 2025
ghstack-source-id: ec84025
Pull-Request: #161927
@malfet malfet added the topic: improvements topic category label Sep 2, 2025
@malfet
Copy link
Contributor

malfet commented Sep 2, 2025

@pytorchbot merge -f "No need to wait for trunc"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@github-actions github-actions bot deleted the gh/kurtamohler/49/head branch October 3, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants