KEMBAR78
fix to segmentation fault when empty tensor is passed to choose_qpara… by arkadip-maitra · Pull Request #161966 · pytorch/pytorch · GitHub
Skip to content

fix to segmentation fault when empty tensor is passed to choose_qpara… #161966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix to segmentation fault when empty tensor is passed to choose_qpara… #161966

wants to merge 3 commits into from

Conversation

@arkadip-maitra
Copy link
Contributor

…ms_optimized

Fixes #153326

Minimal code to reproduce error:

import torch

tensor = torch.tensor([])

torch.choose_qparams_optimized(
    tensor,
    0,
    200,
    0.16,
    8
)

Previous Output:
Segmentation fault

Now Output:

Traceback (most recent call last):
  File "/home/amaitra/work/tests/issue_153326.py", line 5, in <module>
    torch.choose_qparams_optimized(
RuntimeError: input tensor is empty and has no data

Caused because const float* input_row =input_tensor.const_data_ptr<float>(); becomes null

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161966

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e073809 with merge base f8ffa91 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Sep 2, 2025
Skylion007
Skylion007 reviewed Sep 2, 2025
View reviewed changes
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 3, 2025
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 3, 2025
Skylion007
Skylion007 reviewed Sep 3, 2025
View reviewed changes
aten/src/ATen/native/quantized/QTensor.cpp
const float* input_row = input_tensor.const_data_ptr<float>();
TORCH_CHECK_VALUE(input_row != nullptr, "input tensor is empty and has no data");

if (numel < 0 || numel > input_tensor.numel()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually occurred me about whether numel 0 is ever actually valid here, but I don't think we have 0 dim tensors and I don't know how they are treated offhand

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@arkadip-maitra @markc-614
fix to segmentation fault when empty tensor is passed to choose_qpara… (
8371697 
pytorch#161966)

…ms_optimized

Fixes pytorch#153326

Minimal code to reproduce error:
```
import torch

tensor = torch.tensor([])

torch.choose_qparams_optimized(
    tensor,
    0,
    200,
    0.16,
    8
)
```

Previous Output:
`Segmentation fault`

Now Output:
```
Traceback (most recent call last):
  File "/home/amaitra/work/tests/issue_153326.py", line 5, in <module>
    torch.choose_qparams_optimized(
RuntimeError: input tensor is empty and has no data
```

Caused because `const float* input_row =input_tensor.const_data_ptr<float>();` becomes null
Pull Request resolved: pytorch#161966
Approved by: https://github.com/Skylion007
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@arkadip-maitra @mansiag05
fix to segmentation fault when empty tensor is passed to choose_qpara… (
37d0c7a 
pytorch#161966)

…ms_optimized

Fixes pytorch#153326

Minimal code to reproduce error:
```
import torch

tensor = torch.tensor([])

torch.choose_qparams_optimized(
    tensor,
    0,
    200,
    0.16,
    8
)
```

Previous Output:
`Segmentation fault`

Now Output:
```
Traceback (most recent call last):
  File "/home/amaitra/work/tests/issue_153326.py", line 5, in <module>
    torch.choose_qparams_optimized(
RuntimeError: input tensor is empty and has no data
```

Caused because `const float* input_row =input_tensor.const_data_ptr<float>();` becomes null
Pull Request resolved: pytorch#161966
Approved by: https://github.com/Skylion007
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@arkadip-maitra @dsashidh
fix to segmentation fault when empty tensor is passed to choose_qpara… (
17b918d 
pytorch#161966)

…ms_optimized

Fixes pytorch#153326

Minimal code to reproduce error:
```
import torch

tensor = torch.tensor([])

torch.choose_qparams_optimized(
    tensor,
    0,
    200,
    0.16,
    8
)
```

Previous Output:
`Segmentation fault`

Now Output:
```
Traceback (most recent call last):
  File "/home/amaitra/work/tests/issue_153326.py", line 5, in <module>
    torch.choose_qparams_optimized(
RuntimeError: input tensor is empty and has no data
```

Caused because `const float* input_row =input_tensor.const_data_ptr<float>();` becomes null
Pull Request resolved: pytorch#161966
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@salilsdesai salilsdesai Awaiting requested review from salilsdesai salilsdesai is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@jianyuh jianyuh Awaiting requested review from jianyuh jianyuh is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: quantization release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segmentation fault when calling torch.choose_qparams_optimized() with empty tensors and extreme num_bins value

5 participants

@arkadip-maitra @Skylion007 @pytorchmergebot @zou3519 @pytorchbot