Fixed comment to match logic in distributed_c10d.py #162158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
oncall: distributed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162158
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4900a32 with merge base 9c95772 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codeboi007
force-pushed
the
backend-comment-fix
branch
from
23f8a89 to
b4d91d3
Compare
wconstab
approved these changes
Sep 4, 2025
| # will be created, we use nccl(if cuda is available) or gloo as default | ||
| # backend so we can correctly call getDefaultBackend which in ProcessGroup. | ||
| # Currently when backend is UNDEFINED, only one backend will be initialized | ||
| # we use nccl(if cuda is available) or gloo as default backend |
There was a problem hiding this comment.
Nit: put a space after nccl
There was a problem hiding this comment.
Good catch, I'm on it
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
daisyden
pushed a commit
to daisyden/pytorch
that referenced
this pull request
Sep 8, 2025
inconsistent with the logic introduced in pytorch#162157 and modified in pytorch#142216.This update ensures the documentation matches the actual behavior of the code. Pull Request resolved: pytorch#162158 Approved by: https://github.com/wconstab
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
inconsistent with the logic introduced in pytorch#162157 and modified in pytorch#142216.This update ensures the documentation matches the actual behavior of the code. Pull Request resolved: pytorch#162158 Approved by: https://github.com/wconstab
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
inconsistent with the logic introduced in pytorch#162157 and modified in pytorch#142216.This update ensures the documentation matches the actual behavior of the code. Pull Request resolved: pytorch#162158 Approved by: https://github.com/wconstab
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
inconsistent with the logic introduced in pytorch#162157 and modified in pytorch#142216.This update ensures the documentation matches the actual behavior of the code. Pull Request resolved: pytorch#162158 Approved by: https://github.com/wconstab
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
inconsistent with the logic introduced in pytorch#162157 and modified in pytorch#142216.This update ensures the documentation matches the actual behavior of the code. Pull Request resolved: pytorch#162158 Approved by: https://github.com/wconstab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inconsistent with the logic introduced in #162157 and modified in #142216.This update ensures the documentation matches the actual behavior of the code.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim