KEMBAR78
Don't require FakeStore to be passed into fake backend by ezyang · Pull Request #162164 · pytorch/pytorch · GitHub
Skip to content

Don't require FakeStore to be passed into fake backend #162164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't require FakeStore to be passed into fake backend #162164

wants to merge 1 commit into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 4, 2025 •
edited by pytorch-bot bot
Loading

@ezyang
Update
11f9ddd 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Sep 4, 2025
@ezyang
Don't require FakeStore to be passed into fake backend
fdd0318 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 633db04
Pull-Request: #162164
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162164

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 11f9ddd with merge base 8171d60 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Sep 4, 2025
bdhirsh
bdhirsh approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to read more carefully through the interaction between FakeStore and FakeProcessGroup but this seems like a strict improvement to me (passing in both backend="fake" and FakeStore` felt redundant)

wconstab
wconstab approved these changes Sep 4, 2025
View reviewed changes
torch/distributed/distributed_c10d.py
if backend == "fake":
from torch.testing._internal.distributed.fake_pg import FakeStore

store = FakeStore()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error if store kwarg is passed and not a fake store? Or is real store actually supported..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea! I am happy to trial a type check on the store.

@ezyang
Copy link
Contributor Author

ezyang commented Sep 4, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 4, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@ezyang @markc-614
Don't require FakeStore to be passed into fake backend (pytorch#162164)
d74d89e 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#162164
Approved by: https://github.com/bdhirsh, https://github.com/albanD, https://github.com/wconstab
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@ezyang @mansiag05
Don't require FakeStore to be passed into fake backend (pytorch#162164)
9a49911 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#162164
Approved by: https://github.com/bdhirsh, https://github.com/albanD, https://github.com/wconstab
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@ezyang @cleonard530
Don't require FakeStore to be passed into fake backend (pytorch#162164)
a84a051 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#162164
Approved by: https://github.com/bdhirsh, https://github.com/albanD, https://github.com/wconstab
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@ezyang @dsashidh
Don't require FakeStore to be passed into fake backend (pytorch#162164)
8a1068b 
Signed-off-by: Edward Yang <ezyang@meta.com>

Pull Request resolved: pytorch#162164
Approved by: https://github.com/bdhirsh, https://github.com/albanD, https://github.com/wconstab
@github-actions github-actions bot deleted the gh/ezyang/3142/head branch October 5, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wconstab wconstab wconstab approved these changes

@albanD albanD albanD approved these changes

@bdhirsh bdhirsh bdhirsh approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ezyang @pytorchmergebot @wconstab @albanD @bdhirsh @facebook-github-bot