KEMBAR78
[BE] Update Python min version to 3.10 by malfet · Pull Request #162310 · pytorch/pytorch · GitHub
Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 5, 2025

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162310

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 90 Pending

As of commit 6fb0f08 with merge base 3a7db34 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 5, 2025
malfet added a commit that referenced this pull request Sep 5, 2025
ghstack-source-id: c029680
Pull Request resolved: #162310
@malfet malfet requested review from Skylion007 and albanD September 5, 2025 22:57
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you.

@malfet
Copy link
Contributor Author

malfet commented Sep 5, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 5, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably need to run ruff to run the pyupgrade rules FYI

[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 13, 2025
ghstack-source-id: 21d346b
Pull Request resolved: #162310
malfet added a commit that referenced this pull request Sep 13, 2025
ghstack-source-id: 24037dd
Pull Request resolved: #162310
@atalman atalman added this to the 2.9.0 milestone Sep 13, 2025
malfet added a commit that referenced this pull request Sep 14, 2025
ghstack-source-id: 5925f92
Pull Request resolved: #162310
malfet added a commit that referenced this pull request Sep 14, 2025
ghstack-source-id: bdf75c3
Pull Request resolved: #162310
@malfet malfet requested a review from a team as a code owner September 14, 2025 20:29
malfet added a commit that referenced this pull request Sep 14, 2025
ghstack-source-id: d98d09f
Pull Request resolved: #162310
malfet added a commit that referenced this pull request Sep 14, 2025
ghstack-source-id: 89fa425
Pull Request resolved: #162310
@malfet
Copy link
Contributor Author

malfet commented Sep 22, 2025

@pytorchbot merge -f "Run lint locally, but not entirely sure if it'll be green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Camyll
Copy link
Contributor

Camyll commented Sep 22, 2025

@pytorchbot cherry-pick --onto release/2.9 --c critical --fixes #161167

@pytorchbot
Copy link
Collaborator

Cherry picking #162310

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 5e7be988003a38be49227cfaa9bff6a2ea9e6929 returned non-zero exit code 1

Auto-merging .ci/docker/build.sh
Auto-merging .github/workflows/docker-builds.yml
CONFLICT (content): Merge conflict in .github/workflows/docker-builds.yml
Auto-merging .github/workflows/lint.yml
Auto-merging pyproject.toml
Auto-merging setup.py
error: could not apply 5e7be988003... [BE] Update Python min version to 3.10 (#162310)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@malfet malfet added topic: bc breaking topic category and removed topic: not user facing topic category labels Sep 23, 2025
@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Camyll pushed a commit that referenced this pull request Sep 24, 2025
Camyll added a commit that referenced this pull request Sep 24, 2025
Pull Request resolved: #162310
Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi
ghstack dependencies: #162862

Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
atalman added a commit that referenced this pull request Sep 25, 2025
Camyll pushed a commit that referenced this pull request Sep 25, 2025
Revert "[BE] Update Python min version to 3.10 (#162310) (#163802)"

This reverts commit 7d024a6.
@Camyll
Copy link
Contributor

Camyll commented Sep 25, 2025

@pytorchbot cherry-pick --onto release/2.9 -c critical

@pytorchbot
Copy link
Collaborator

Cherry picking #162310

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 5e7be988003a38be49227cfaa9bff6a2ea9e6929 returned non-zero exit code 1

Auto-merging .ci/docker/build.sh
Auto-merging .github/workflows/docker-builds.yml
CONFLICT (content): Merge conflict in .github/workflows/docker-builds.yml
Auto-merging .github/workflows/lint.yml
Auto-merging pyproject.toml
Auto-merging setup.py
error: could not apply 5e7be988003... [BE] Update Python min version to 3.10 (#162310)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

Camyll added a commit that referenced this pull request Sep 25, 2025
* [BE] Update Python min version to 3.10 (#162310)

Pull Request resolved: #162310
Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi

* comment out executorch

---------

Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
This reverts commit 3016616.

Reverted pytorch#162310 on behalf of https://github.com/malfet due to Breaks some windows tests ([comment](pytorch#162862 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
This reverts commit 9f5a644.

Reverted pytorch#162310 on behalf of https://github.com/malfet due to Broke lint, but to the best of my knowledge it's no longer possible to run lint for all files on PRs ([comment](pytorch#162310 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: bc breaking topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants