-
Notifications
You must be signed in to change notification settings - Fork 25.7k
CD Windows CUDA 13.0 build - fix packaging of cuda dlls #162383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162383
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 53 PendingAs of commit c058c29 with merge base 4d4abec ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but sad that we have to have this conditional logic.
| copy "%CUDA_PATH%\bin\cufft*64_*.dll*" pytorch\torch\lib | ||
| copy "%CUDA_PATH%\bin\cusolver*64_*.dll*" pytorch\torch\lib | ||
|
|
||
| if %CUDA_VERSION% geq 130 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nWEIdia can we get a sense from the NVIDIA team why this changed and if this is documented anywhere? I'd ideally like to not have to have this conditional logic here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we shipping slim builds on Windows?
|
@pytorchmergebot merge -f "build is passing" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Trying to fix pytorch#162333 CUDA 13.0 file structure changed. Instead of keeping most of dlls in bin folder its now in ``bin\x64`` except for cudnn dll. See attached picture : <img width="511" height="361" alt="Screenshot 2025-09-08 at 9 46 26 AM" src="https://github.com/user-attachments/assets/d2e630ee-930f-4da6-9b81-f9ef48fde7ce" /> <img width="490" height="333" alt="Screenshot 2025-09-08 at 9 46 34 AM" src="https://github.com/user-attachments/assets/194cbf43-b6ef-4218-b516-db37b91302be" /> Pull Request resolved: pytorch#162383 Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/malfet
Trying to fix pytorch#162333 CUDA 13.0 file structure changed. Instead of keeping most of dlls in bin folder its now in ``bin\x64`` except for cudnn dll. See attached picture : <img width="511" height="361" alt="Screenshot 2025-09-08 at 9 46 26 AM" src="https://github.com/user-attachments/assets/d2e630ee-930f-4da6-9b81-f9ef48fde7ce" /> <img width="490" height="333" alt="Screenshot 2025-09-08 at 9 46 34 AM" src="https://github.com/user-attachments/assets/194cbf43-b6ef-4218-b516-db37b91302be" /> Pull Request resolved: pytorch#162383 Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/malfet
Trying to fix pytorch#162333 CUDA 13.0 file structure changed. Instead of keeping most of dlls in bin folder its now in ``bin\x64`` except for cudnn dll. See attached picture : <img width="511" height="361" alt="Screenshot 2025-09-08 at 9 46 26 AM" src="https://github.com/user-attachments/assets/d2e630ee-930f-4da6-9b81-f9ef48fde7ce" /> <img width="490" height="333" alt="Screenshot 2025-09-08 at 9 46 34 AM" src="https://github.com/user-attachments/assets/194cbf43-b6ef-4218-b516-db37b91302be" /> Pull Request resolved: pytorch#162383 Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/malfet
Trying to fix pytorch#162333 CUDA 13.0 file structure changed. Instead of keeping most of dlls in bin folder its now in ``bin\x64`` except for cudnn dll. See attached picture : <img width="511" height="361" alt="Screenshot 2025-09-08 at 9 46 26 AM" src="https://github.com/user-attachments/assets/d2e630ee-930f-4da6-9b81-f9ef48fde7ce" /> <img width="490" height="333" alt="Screenshot 2025-09-08 at 9 46 34 AM" src="https://github.com/user-attachments/assets/194cbf43-b6ef-4218-b516-db37b91302be" /> Pull Request resolved: pytorch#162383 Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/malfet
Trying to fix #162333
CUDA 13.0 file structure changed. Instead of keeping most of dlls in bin folder its now in


bin\x64except for cudnn dll. See attached picture :