KEMBAR78
Fix warn message by drisspg · Pull Request #163578 · pytorch/pytorch · GitHub
Skip to content

Fix warn message #163578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix warn message #163578

wants to merge 1 commit into from

Conversation

@drisspg
Copy link
Contributor

@drisspg drisspg commented Sep 22, 2025 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

cc @Chillee @yanboliang @BoyuanFeng

@drisspg
Update
86a11d7 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163578

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 86a11d7 with merge base b756b58 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Sep 22, 2025
@drisspg
Fix warn message
8be1e5f 
ghstack-source-id: 270fe57
Pull-Request: #163578
@drisspg drisspg added this to the 2.9.0 milestone Sep 22, 2025
@drisspg drisspg requested review from BoyuanFeng, Chillee and v0i0 and removed request for albanD, jbschlosser and mikaylagawarecki September 22, 2025 22:26
albanD
albanD approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha

@drisspg
Copy link
Contributor Author

drisspg commented Sep 22, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 22, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Skylion007
Skylion007 approved these changes Sep 22, 2025
View reviewed changes
torch/nn/attention/flex_attention.py
"return_lse is deprecated and will be removed in v2.7. "
"return_lse is deprecated and will be removed in v2.10. "
"Please use return_aux=AuxRequest(lse=True) instead.",
category=FutureWarning,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we increase the stack_level here?

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_12-cuda12_8-test / test

Details for Dev Infra team Raised by workflow job

@drisspg
Copy link
Contributor Author

drisspg commented Sep 23, 2025

@pytorchbot merge -i

@drisspg
Copy link
Contributor Author

drisspg commented Sep 23, 2025

@pytorchbot merge -f

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@drisspg
Copy link
Contributor Author

drisspg commented Sep 23, 2025

@pytorchbot merge -f "please land this should have landed already "

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@drisspg @dsashidh
Fix warn message (pytorch#163578)
e1aae6a 
Pull Request resolved: pytorch#163578
Approved by: https://github.com/albanD, https://github.com/Skylion007, https://github.com/atalman, https://github.com/v0i0
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@drisspg @jainapurva
Fix warn message (#163578)
72c19b8 
Pull Request resolved: #163578
Approved by: https://github.com/albanD, https://github.com/Skylion007, https://github.com/atalman, https://github.com/v0i0
@pytorch pytorch deleted a comment from pytorch-bot bot Oct 1, 2025
@Camyll
Copy link
Contributor

Camyll commented Oct 1, 2025

@pytorchbot cherry-pick --onto release/2.9 --c critical

pytorchbot pushed a commit that referenced this pull request Oct 1, 2025
@drisspg @pytorchbot
Fix warn message (#163578)
9ab2ce5 
Pull Request resolved: #163578
Approved by: https://github.com/albanD, https://github.com/Skylion007, https://github.com/atalman, https://github.com/v0i0

(cherry picked from commit f3f67ff)
@pytorchbot pytorchbot mentioned this pull request Oct 1, 2025
Merged
@pytorchbot
Copy link
Collaborator

Cherry picking #163578

The cherry pick PR is at #164367 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 1, 2025
Closed
Camyll pushed a commit that referenced this pull request Oct 1, 2025
@pytorchbot @drisspg
Fix warn message (#164367)
3abee62 
Fix warn message (#163578)

Pull Request resolved: #163578
Approved by: https://github.com/albanD, https://github.com/Skylion007, https://github.com/atalman, https://github.com/v0i0

(cherry picked from commit f3f67ff)

Co-authored-by: drisspg <drisspguessous@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

@v0i0 v0i0 v0i0 approved these changes

@atalman atalman atalman approved these changes

@Chillee Chillee Awaiting requested review from Chillee

@BoyuanFeng BoyuanFeng Awaiting requested review from BoyuanFeng

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: flex attention release notes: nn release notes category

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

8 participants

@drisspg @pytorchmergebot @Camyll @pytorchbot @Skylion007 @albanD @v0i0 @atalman