KEMBAR78
[c10d] P2P tensors must be dense by kwen2501 · Pull Request #163719 · pytorch/pytorch · GitHub
Skip to content

Conversation

@kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented Sep 24, 2025

Stack from ghstack (oldest at bottom):

Fixes #161324
by adding is_non_overlapping_and_dense check.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim @dcci

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Sep 24, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163719

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b6ce882 with merge base 8d81564 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kwen2501 added a commit that referenced this pull request Sep 24, 2025
ghstack-source-id: c6ae065
Pull-Request: #163719
[ghstack-poisoned]
kwen2501 added a commit that referenced this pull request Sep 24, 2025
ghstack-source-id: 782bf7b
Pull-Request: #163719
@kwen2501 kwen2501 requested a review from ngimel September 24, 2025 01:48
@kwen2501
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kwen2501
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/2.9 --fixes #161324

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@kwen2501
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/2.9 -c critical --fixes #161324

pytorchbot pushed a commit that referenced this pull request Sep 26, 2025
Fixes #161324
by adding `is_non_overlapping_and_dense` check.

Pull Request resolved: #163719
Approved by: https://github.com/ngimel

(cherry picked from commit 11a231e)
@pytorchbot
Copy link
Collaborator

Cherry picking #163719

The cherry pick PR is at #163981 and it is linked with issue #161324. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@kwen2501 kwen2501 added the topic: bug fixes topic category label Sep 26, 2025
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
Fixes pytorch#161324
by adding `is_non_overlapping_and_dense` check.

Pull Request resolved: pytorch#163719
Approved by: https://github.com/ngimel
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
Fixes #161324
by adding `is_non_overlapping_and_dense` check.

Pull Request resolved: #163719
Approved by: https://github.com/ngimel
Camyll pushed a commit that referenced this pull request Sep 29, 2025
[c10d] P2P tensors must be dense (#163719)

Fixes #161324
by adding `is_non_overlapping_and_dense` check.

Pull Request resolved: #163719
Approved by: https://github.com/ngimel

(cherry picked from commit 11a231e)

Co-authored-by: Ke Wen <kw2501@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants