Reapply "Make functionalization ViewMeta serializable with pickle. (#143712)"
#163769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucaskabela
requested review from
Chillee,
albanD,
bdhirsh,
ezyang and
soulitzer
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163769
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 296733f with merge base 754c7e2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating diff in D81524507. |
|
Copying justification from other PR:
|
Lucaskabela
added
suppress-bc-linter
Lucaskabela
changed the title
ViewMeta serializable with pickle. (#143712)" (#161994)ViewMeta serializable with pickle. (#143712)"
1 task
|
@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating diff in D81524507. |
Lucaskabela
force-pushed
the
export-D81524507
branch
from
f679369 to
16a707f
Compare
Lucaskabela
pushed a commit
to Lucaskabela/pytorch
that referenced
this pull request
Sep 24, 2025
…ytorch#143712)" (pytorch#163769) Summary: Pull Request resolved: pytorch#163769 Pull Request resolved: pytorch#161994 Attempted rebase of pytorch#143712. First I'm sanity checking that OSS CI passes. I'll probably need to abandon this PR and make a diff to check internal CI This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Differential Revision: D81524507 Pulled By: Lucaskabela
dolpm
approved these changes
Sep 24, 2025
|
@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating diff in D81524507. |
Lucaskabela
force-pushed
the
export-D81524507
branch
from
16a707f to
1f544bd
Compare
Lucaskabela
pushed a commit
to Lucaskabela/pytorch
that referenced
this pull request
Sep 24, 2025
…ytorch#143712)" (pytorch#163769) Summary: Pull Request resolved: pytorch#163769 Pull Request resolved: pytorch#161994 Attempted rebase of pytorch#143712. First I'm sanity checking that OSS CI passes. I'll probably need to abandon this PR and make a diff to check internal CI This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Reviewed By: dolpm Differential Revision: D81524507 Pulled By: Lucaskabela
|
@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating diff in D81524507. |
Lucaskabela
pushed a commit
to Lucaskabela/pytorch
that referenced
this pull request
Sep 24, 2025
…ytorch#143712)" (pytorch#163769) Summary: Pull Request resolved: pytorch#163769 Pull Request resolved: pytorch#161994 Attempted rebase of pytorch#143712. First I'm sanity checking that OSS CI passes. I'll probably need to abandon this PR and make a diff to check internal CI This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Reviewed By: dolpm Differential Revision: D81524507 Pulled By: Lucaskabela
Lucaskabela
force-pushed
the
export-D81524507
branch
from
1f544bd to
d2bec95
Compare
|
@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating diff in D81524507. |
Lucaskabela
pushed a commit
to Lucaskabela/pytorch
that referenced
this pull request
Sep 24, 2025
…ytorch#143712)" (pytorch#163769) Summary: Pull Request resolved: pytorch#163769 Pull Request resolved: pytorch#161994 Attempted rebase of pytorch#143712. First I'm sanity checking that OSS CI passes. I'll probably need to abandon this PR and make a diff to check internal CI This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Reviewed By: dolpm Differential Revision: D81524507 Pulled By: Lucaskabela
Lucaskabela
force-pushed
the
export-D81524507
branch
from
d2bec95 to
ab23a15
Compare
…ytorch#143712)" (pytorch#163769) Summary: Pull Request resolved: pytorch#163769 Pull Request resolved: pytorch#161994 Attempted rebase of pytorch#143712. First I'm sanity checking that OSS CI passes. I'll probably need to abandon this PR and make a diff to check internal CI This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Reviewed By: dolpm Differential Revision: D81524507 Pulled By: Lucaskabela
|
@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating diff in D81524507. |
Lucaskabela
force-pushed
the
export-D81524507
branch
from
ab23a15 to
296733f
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.9 --fixes vllm-project/vllm#24547 -c regression |
|
For context for dev-infra team: This PR, along with #163571, is required to fix a major issue with standalone compile for some models in vLLM (Gemma3, Qwen3) which was unmasked in 2.8. We need these to be cherrypicked in 2.9, otherwise standalone compile will be turned off for ~2-3 months (until these PRs are released in another branch cut) |
Cherry picking #163769Command Details for Dev Infra teamRaised by workflow job |
Lucaskabela
pushed a commit
that referenced
this pull request
Sep 25, 2025
…143712)" (#163769) NOTE: This is a re-export of #161994 ; the changes between these two PRs is exclusively to the buck/build files (Summary from #161994 ) Attempted rebase of #143712. This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Differential Revision: D81524507 Pulled By: Lucaskabela Pull Request resolved: #163769 Approved by: https://github.com/dolpm Co-authored-by: Brian Hirsh <hirsheybar@fb.com> (cherry picked from commit 7d71040)
Lucaskabela
pushed a commit
that referenced
this pull request
Sep 25, 2025
…143712)" (#163769) NOTE: This is a re-export of #161994 ; the changes between these two PRs is exclusively to the buck/build files (Summary from #161994 ) Attempted rebase of #143712. This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Differential Revision: D81524507 Pulled By: Lucaskabela Pull Request resolved: #163769 Approved by: https://github.com/dolpm Co-authored-by: Brian Hirsh <hirsheybar@fb.com> (cherry picked from commit 7d71040)
|
Manual cherry pick: #163873 |
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
…143712)" (#163769) ### Summary: NOTE: This is a re-export of #161994 ; the changes between these two PRs is exclusively to the buck/build files (Summary from #161994 ) Attempted rebase of #143712. This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Differential Revision: D81524507 Pulled By: Lucaskabela Pull Request resolved: #163769 Approved by: https://github.com/dolpm Co-authored-by: Brian Hirsh <hirsheybar@fb.com>
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 2, 2025
…143712)" (#163769) NOTE: This is a re-export of #161994 ; the changes between these two PRs is exclusively to the buck/build files (Summary from #161994 ) Attempted rebase of #143712. This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Differential Revision: D81524507 Pulled By: Lucaskabela Pull Request resolved: #163769 Approved by: https://github.com/dolpm Co-authored-by: Brian Hirsh <hirsheybar@fb.com> (cherry picked from commit 7d71040)
atalman
pushed a commit
that referenced
this pull request
Oct 2, 2025
…zation ViewMeta serializable with pickle #163769` (#163873) Reapply "Make functionalization `ViewMeta` serializable with pickle. (#143712)" (#163769) NOTE: This is a re-export of #161994 ; the changes between these two PRs is exclusively to the buck/build files (Summary from #161994 ) Attempted rebase of #143712. This reverts commit 6c713cc. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela imported-using-ghimport Test Plan: Imported from OSS Differential Revision: D81524507 Pulled By: Lucaskabela Pull Request resolved: #163769 Approved by: https://github.com/dolpm (cherry picked from commit 7d71040) Co-authored-by: Brian Hirsh <hirsheybar@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: This is a re-export of #161994 ; the changes between these two PRs is exclusively to the buck/build files
(Summary from #161994 )
Attempted rebase of #143712.
This reverts commit 6c713cc.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela
imported-using-ghimport
Test Plan: Imported from OSS
Differential Revision: D81524507
Pulled By: Lucaskabela
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames