Fix issue with scalars and __rpow__ #16687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: - Modify __rpow__ function in tensor.py to adapt to scalars Test plan: - Add scalar entry in test_rpow - Add CUDA port
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
pushed a commit
that referenced
this pull request
Feb 3, 2019
Summary: Changelog: - Modify __rpow__ function in tensor.py to adapt to scalars Pull Request resolved: #16687 Differential Revision: D13936720 Pulled By: soumith fbshipit-source-id: b0c8727968b04efbc6e7461807c812d962f03370
ssnl
reviewed
Feb 3, 2019
|
|
||
| def __rpow__(self, other): | ||
| return self.new([other]) ** self | ||
| return self.new_tensor(other) ** self |
There was a problem hiding this comment.
shouldn't this be as_tensor? Also, new_tensor throws a warning when the input is already a tensor...
There was a problem hiding this comment.
If other is a tensor, then this would be dispatched to the __pow__ function instead right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Test plan:
Fixes #16685