[easy] Enforce non-negativity of tensor construction #17077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@dzhulgakov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Feb 14, 2019
|
We have a generic problem where there are a lot of places where we are missing "common sense" checks like this. Probably the only way to squash them all out is with THE POWER OF TYPES |
apaszke
reviewed
Feb 19, 2019
There was a problem hiding this comment.
nit: check_size_nonnegative? This sounds really generic.
dzhulgakov
force-pushed
the
negative-size
branch
from
38a2186 to
d54cc7c
Compare
There was a problem hiding this comment.
@dzhulgakov is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Feb 21, 2019
Summary: Apparently, before the only way we enforced it was size>=0 in alloc_cpu. So empty((5,-5)) would fail but empty((-5,-5)) would hang :) Please suggest better place to enforce it if any. Pull Request resolved: pytorch/pytorch#17077 Differential Revision: D14077930 Pulled By: dzhulgakov fbshipit-source-id: 1120513300fd5448e06fa15c2d72f9b0ee5734e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, before the only way we enforced it was size>=0 in alloc_cpu. So empty((5,-5)) would fail but empty((-5,-5)) would hang :)
Please suggest better place to enforce it if any.