KEMBAR78
Move argsort to C++ by zasdfgbnm · Pull Request #17099 · pytorch/pytorch · GitHub
Skip to content

Move argsort to C++ #17099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Move argsort to C++ #17099

wants to merge 6 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

No description provided.

@gchanan
Copy link
Contributor

gchanan commented Feb 20, 2019

looks like you hit a merge conflict.

@zasdfgbnm
Copy link
Collaborator Author

@gchanan resolved

@ezyang
Copy link
Contributor

ezyang commented Feb 21, 2019

@pytorchbot rebase this please

@ezyang
Copy link
Contributor

ezyang commented Feb 21, 2019

Verified that the previous docs were wrong:

>>> torch.sort(torch.randn(3), dim=None)                                     
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: sort(): argument 'dim' must be int, not NoneType                  
>>> torch.sort(torch.randn(3), dim=-1)                                       
(tensor([-0.8905,  0.3219,  1.4383]), tensor([0, 1, 2]))

facebook-github-bot
facebook-github-bot reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the argsort branch February 21, 2019 17:26
zdevito pushed a commit to zdevito/ATen that referenced this pull request Feb 21, 2019
@zasdfgbnm @facebook-github-bot
Move argsort to C++
5931cd5 
Summary: Pull Request resolved: pytorch/pytorch#17099

Differential Revision: D14165671

Pulled By: ezyang

fbshipit-source-id: 3871de6874fe09871ebd9b8943c13c9af325bf33
@tczhangzhi tczhangzhi mentioned this pull request Aug 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zasdfgbnm @gchanan @ezyang @facebook-github-bot