[DOC][MINOR] Missing argument description (value) in scatter_ function documentation #17467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnakalyan3
force-pushed
the
scatter-fix
branch
from
1045300 to
513f79e
Compare
soumith
requested changes
Feb 25, 2019
krishnakalyan3
force-pushed
the
scatter-fix
branch
2 times, most recently
from
205e9ff to
513f79e
Compare
krishnakalyan3
force-pushed
the
scatter-fix
branch
from
009e768 to
a0d4daa
Compare
|
@soumith sorry for the inconvenience. Could you please have a look at the changes again?. |
soumith
approved these changes
Feb 25, 2019
|
thank you! |
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 25, 2019
…on (#17467) Summary: Update the docs to include the value parameter that was missing in the `scatter_` function. Differential Revision: D14209225 Pulled By: soumith fbshipit-source-id: 5c65e4d8fbd93fcd11a0a47605bce6d57570f248
|
closed via 59ece70 |
|
The bug still persists, why did we delete the scatter fix? please fix this. or may be I can create another pull request for the same fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs to include the value parameter that was missing in the
scatter_function.cc: @fmassa @vishwakftw @soumith
Ref:
#16014