Enabled HALF for fill() and zero() methods. Moved them into THTensorFill #17536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@izdeby has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
reviewed
Feb 27, 2019
ezyang
approved these changes
Feb 27, 2019
zou3519
reviewed
Feb 27, 2019
| name: _th_zero_ | ||
| cname: zero | ||
| return: self | ||
| cpu_half: True |
There was a problem hiding this comment.
Add cpu_half test maybe to test_torch?
There was a problem hiding this comment.
zero() and fill() are heavily used in tests, but its a good point about adding a specific test for half type only. this PR is landing right now but i will add these tests as a part of next PR which is in progress right now.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Feb 27, 2019
…ill (#17536) Summary: For some additional context on this change, please, see this [PR](pytorch/pytorch#17376) As a part of work on Bool Tensor, we will need to add support for a bool type to _fill() and _zero() methods that are currently located in THTensorMath. As we don't need anything else and those methods are not really math related - we are moving them out into separate THTensorFill for simplicity. Change: -moved _fill() and _zero() from THTensorMath.h to THTensorFill -enabled _fill() and _zero() for HALF type. Pull Request resolved: pytorch/pytorch#17536 Differential Revision: D14242130 Pulled By: izdeby fbshipit-source-id: 1d8bd806f0f5510723b9299d360b70cc4ab96afb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some additional context on this change, please, see this PR
As a part of work on Bool Tensor, we will need to add support for a bool type to _fill() and _zero() methods that are currently located in THTensorMath. As we don't need anything else and those methods are not really math related - we are moving them out into separate THTensorFill for simplicity.
Change:
-moved _fill() and _zero() from THTensorMath.h to THTensorFill
-enabled _fill() and _zero() for HALF type.