[jit] Add string index/slice operations #18247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for string indexing (`"a"[0]`) and slicing (`"abc"[1:3]`) to script.
facebook-github-bot
added
the
oncall: jit
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
suo
reviewed
Mar 22, 2019
added 2 commits
March 28, 2019 10:50
suo
approved these changes
Apr 1, 2019
torch/csrc/jit/register_prim_ops.cpp
Outdated
| } | ||
|
|
||
| std::string result; | ||
| result.insert(result.begin(), string.begin() + start, string.begin() + end); |
There was a problem hiding this comment.
you don't need an extra insert(), just use the constructor e.g. std::string result(string, start, end-start)
There was a problem hiding this comment.
@driazati is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
fmassa
reviewed
Apr 1, 2019
| {"max", std::make_shared<BuiltinFunction>(prim::max, at::nullopt)}, | ||
| {"list", std::make_shared<BuiltinFunction>(aten::list, at::nullopt)}, | ||
| {"ord", std::make_shared<BuiltinFunction>(aten::ord, at::nullopt)}, | ||
| {"rangelist", std::make_shared<BuiltinFunction>(prim::rangelist, at::nullopt)}, |
There was a problem hiding this comment.
Nit: is this line a duplicate of the line below?
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 1, 2019
Summary: Adds support for string indexing (`"a"[0]`) and slicing (`"abc"[1:3]`) to script. Pull Request resolved: pytorch/pytorch#18247 Differential Revision: D14574486 Pulled By: driazati fbshipit-source-id: 4b42aa0881e5398ea7f112be46c0335e6e19dced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for string indexing (
"a"[0]) and slicing ("abc"[1:3])to script.