KEMBAR78
fix arange shape issue inconsistency across cpu and cuda by soumith · Pull Request #18462 · pytorch/pytorch · GitHub
Skip to content

Conversation

@soumith
Copy link
Member

@soumith soumith commented Mar 26, 2019

Fixes #18363

@soumith soumith requested a review from colesbury March 26, 2019 02:57
# check that it holds a consistent output shape on precision-cornered step sizes
d = torch.arange(-4.0, 4.0, 0.01, dtype=torch.float32, device=device)
self.assertEqual(d.shape[0], 800)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint

Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for the lint

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Mar 26, 2019
Summary:
Fixes pytorch/pytorch#18363
Pull Request resolved: pytorch/pytorch#18462

Differential Revision: D14620263

Pulled By: soumith

fbshipit-source-id: 223524cdda2f5d55c2ca8d4cdcf6f7a05a6c15eb
@facebook-github-bot
Copy link
Contributor

@soumith merged this pull request in 4367231.

@soumith soumith deleted the arange_fix branch April 7, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arange cuda bug

3 participants