Fix torch::nn::init::orthogonal_ with CNNs #18915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't touched any Python files, so I assume the Python lint checks were already failing before this commit. |
vishwakftw
reviewed
Apr 5, 2019
Omegastick
requested review from
apaszke,
ezyang,
fmassa,
mrshenli,
pietern and
soumith
as code owners
|
@Omegastick Thank you. Can we get a little test for this case? @pytorchbot rebase this please |
|
@ezyang Right, how's that? Let me know if I did something wrong with the test, I'm not too familiar with PyTorch's tests. |
vishwakftw
reviewed
Apr 8, 2019
ezyang
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Fixes pytorch#18518 I changed the C++ API torch::nn::init::orthogonal_ implementation to match the Python implementation. Pull Request resolved: pytorch#18915 Differential Revision: D14851833 Pulled By: ezyang fbshipit-source-id: 45b5e9741582777c203e9ebed564ab3ac1f94baf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18518
I changed the C++ API torch::nn::init::orthogonal_ implementation to match the Python implementation.