[jit] Fix ord() when dealing with utf8 chars #19423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nairbv
reviewed
Apr 18, 2019
test/test_jit.py
Outdated
| self.checkScript(fn, ("h")) | ||
| self.checkScript(fn, ("y")) | ||
|
|
||
| s = u'\u00a3' |
There was a problem hiding this comment.
looks like this s is unused?
gh-metadata: pytorch pytorch 19435 gh/driazati/17/head
driazati
force-pushed
the
gh/driazati/16/head
branch
from
4abc2ab to
22cd308
Compare
suo
approved these changes
Apr 19, 2019
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19423 ghimport-source-id: e744948 Reviewed By: eellison Differential Revision: D15002847 Pulled By: driazati fbshipit-source-id: 4560cebcfca695447423d48d65ed364e7dbdbedb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15002847
Previously utf-8 bytes > 127 were wrapping around to negative values, casting to a
uint8_tfixes this.