Add manual_seed in script #19510
Closed
Add manual_seed in script #19510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
driazati
approved these changes
Apr 19, 2019
suo
reviewed
Apr 19, 2019
| push(stack, a.cpu()); | ||
| return 0; | ||
| }), | ||
| Operator( |
There was a problem hiding this comment.
we should mark this op as having side effects. I'm actually kind of surprised the test didn't have it DCE'd out
There was a problem hiding this comment.
Is there a way of doing that in the schema ? I added it to hasSideEffects() in ir.cpp
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 22, 2019
Summary: Add manual_seed to torch script. Pull Request resolved: pytorch/pytorch#19510 Reviewed By: suo, driazati Differential Revision: D15018823 Pulled By: eellison fbshipit-source-id: d7734a8ad05ba254c0d88abf3fb58c4ce6a4e53b
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Add manual_seed to torch script. Pull Request resolved: pytorch#19510 Reviewed By: suo, driazati Differential Revision: D15018823 Pulled By: eellison fbshipit-source-id: d7734a8ad05ba254c0d88abf3fb58c4ce6a4e53b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add manual_seed to torch script.