Allow target.requires_grad in l1_loss and mse_loss #3876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
reviewed
Nov 25, 2017
torch/nn/functional.py
Outdated
| return loss.sum() | ||
|
|
||
|
|
||
| def _poinwise_loss(lambd, lambd_optimized, input, target, size_average=True, reduce=True): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
apaszke
approved these changes
Nov 26, 2017
|
linter still has a few complaints |
|
@pytorchbot add to whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug cost me a lot of time in several projects, 0.2 would silently accept target.requires_grad and would backprop zeroes in
l1_lossandmse_loss. It's fixed in master already (with exception), and this PR allows target.requires_grad by explicitly defining the loss functions.