KEMBAR78
Fix CUDA index_fill_ boundary check with small tensor size by ssnl · Pull Request #3953 · pytorch/pytorch · GitHub
Skip to content

Fix CUDA index_fill_ boundary check with small tensor size #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix CUDA index_fill_ boundary check with small tensor size #3953

merged 1 commit into from
Nov 30, 2017

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Nov 30, 2017

One character PR :)

Fixes #3922 .

apaszke
apaszke approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loool that's why you don't call variables like this haha

@soumith soumith merged commit fcb0b0d into pytorch:master Nov 30, 2017
@ssnl ssnl deleted the index_fill_cuda branch November 30, 2017 19:44
@soumith soumith added the 0.3.1 label Feb 4, 2018
soumith pushed a commit that referenced this pull request Feb 7, 2018
@ssnl @soumith
fix (#3953)
a9a76c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soumith soumith soumith approved these changes

+1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x.index_fill_() on cuda tensors doesn't do bounds checks

4 participants

@ssnl @soumith @apaszke @ezyang