More strict shape check on Conv operators. #4637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HE, Tao <sighingnow@gmail.com>
Signed-off-by: HE, Tao <sighingnow@gmail.com>
|
@pytorchbot test this please |
|
Maybe cudnn code path also has something that checks this, but it feels that these checks can be at ATen level since they are pretty general, e.g. here https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/Convolution.cpp#L156. |
|
not a bad idea to have them at ATen level, now that it's becoming the way everything is exposed. But it's just a safe thing to fix the THNN checks, they were incorrect. |
soumith
pushed a commit
that referenced
this pull request
Feb 7, 2018
* More strict shape check on Conv operators. Signed-off-by: HE, Tao <sighingnow@gmail.com> * Test case for conv's shape check. Signed-off-by: HE, Tao <sighingnow@gmail.com> * Fix lint. Signed-off-by: HE, Tao <sighingnow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more strict shape check on Conv operators. The computed input size should never less than kernel size.
This patch should fix issue #4607