Add missing _lazy_init in cuda python module #4907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
approved these changes
Jan 29, 2018
|
Thanks Alban! |
|
Please note that _lazy_init messes up context creation (see #4903) and memory use on GPU 0. |
|
Yeah, but what can we do if you ask for a blas handle 😕 But I agree it would be slightly nicer to make |
|
@apaszke sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master raises an error for the blas handle (asking to set the blas handle, which sounds like the wrong error message as it cannot be set from python) and segfaults for the
empty_cache()function.