KEMBAR78
Lazy init order in set device, should not be called in getDevCount by csarofeen · Pull Request #4918 · pytorch/pytorch · GitHub
Skip to content

Lazy init order in set device, should not be called in getDevCount #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2018
Merged

Lazy init order in set device, should not be called in getDevCount #4918

merged 1 commit into from
Jan 30, 2018

Conversation

@csarofeen
Copy link
Contributor

No description provided.

@csarofeen
Copy link
Contributor Author

#4903

@onnxbot-worker-3 onnxbot-worker-3 mentioned this pull request Jan 29, 2018
Closed
apaszke
apaszke suggested changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@apaszke apaszke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the pybind submodule update?

torch/cuda/__init__.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/cuda/__init__.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@csarofeen
Copy link
Contributor Author

The biggest issue seems to be _lazy_init as it is allocating a good chunk of memory that can end up on the wrong device fairly easily the way things are now. Calling device count in pytorch was allocating about 1.5GB on my first device. Device count in pure CUDA was creating ~10MB on each device.

@ngimel ngimel mentioned this pull request Jan 30, 2018
Closed
@soumith soumith merged commit ef4cf86 into pytorch:master Jan 30, 2018
@soumith soumith added the 0.3.1 label Feb 5, 2018
soumith pushed a commit that referenced this pull request Feb 7, 2018
@csarofeen @soumith
Lazy init in set device, also should not be called in getDevCount (#4918
a5fec26 
)
@csarofeen csarofeen deleted the lazy_init branch February 12, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD left review comments

+1 more reviewer

@apaszke apaszke apaszke requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csarofeen @apaszke @albanD @ezyang @soumith