Fix triu and tril for zero-strided inputs on gpu #4962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Jan 31, 2018
apaszke
reviewed
Jan 31, 2018
|
|
||
| precision = custom_precision.get(name, TestCuda.precision) | ||
| for inplace in (True, False): | ||
| if inplace and no_inplace: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
apaszke
approved these changes
Jan 31, 2018
ssnl
added a commit
to ssnl/pytorch
that referenced
this pull request
Jan 31, 2018
This reverts commit 6c197c2.
soumith
pushed a commit
that referenced
this pull request
Jan 31, 2018
* Revert "Clarify grad_input_mask documentation in derivatives.yaml (#4963)" This reverts commit 6f3266b. * Revert "fix triu and tril for zero-strided inputs on gpu (#4962)" This reverts commit 6c197c2. * Revert "Add mutex for CPU RNG and move TH to C++ (#4041)" This reverts commit 96239dd. * Revert "Support multivariate TransformedDistributions (#4937)" This reverts commit ca5071d. * Revert "Only check that arguments are Variables in VariableType (#4943)" This reverts commit d444379. * Revert "torch.set_num_threads sets MKL option too (#4949)" This reverts commit 2aaeec0.
soumith
pushed a commit
that referenced
this pull request
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4840
This assumes that the output tensor for the operation (if you do inplace operation or if you used the
out=flag) does not have a zero-strided dimension.@apaszke iirc this is an assumption that we make all the time right? If so, do we want to explicitly enforce it at the python api level (one linear check of the stride compared to the python wrapping should be small)? Or do we want to say it explicitly in the documentation somewhere?