Fix refcycles in DataParallel scatter and gather #4988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zou3519
force-pushed
the
dataparallel-leak
branch
from
9e48daa to
ccbff5a
Compare
zou3519
changed the title
apaszke
suggested changes
Feb 1, 2018
torch/nn/parallel/scatter_gather.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
zou3519
changed the title
zou3519
force-pushed
the
dataparallel-leak
branch
from
ccbff5a to
0bf5126
Compare
zou3519
changed the title
zou3519
force-pushed
the
dataparallel-leak
branch
from
3699807 to
81973ea
Compare
|
I added a better fix: it turns out that setting the inner functions equal to |
soumith
approved these changes
Feb 5, 2018
apaszke
reviewed
Feb 5, 2018
| try: | ||
| return scatter_map(inputs) | ||
| finally: | ||
| scatter_map = None |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
pushed a commit
that referenced
this pull request
Feb 7, 2018
* Eliminate reference cycles in scatter_gather * Test for refcycles * Better fix * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4865
DataParallel's
scatterandgathermethods contain reference cycles; this PR removes them. I think this is the explanation.There's something up with Python 2.7 that creates reference cycles when a module is replicated, so the unit test I wrote is only for Python 3. As far as I can tell, those reference cycles are created internally by Python so I don't think there's anything we can do about that.
Test Plan
Unit test to test the multi-gpu behavior under Python 3.