Broadcast output requires_grad only if corresponding input requires_grad #5061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
changed the title
soumith
approved these changes
Feb 6, 2018
apaszke
reviewed
Feb 6, 2018
| .. warning:: | ||
| Forward and backwrad hooks defined on :attr:`module` and its submodules | ||
| won't be invoked anymore, unless the hooks are initialized in the | ||
| :meth:`forward` method. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| if not input_requires_grad: | ||
| for output in outputs: | ||
| non_differentiables.append(output[idx]) | ||
| ctx.mark_non_differentiable(*non_differentiables) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids unnecessary computation when finetuning only certain layers with DataParallel.
Fixes #5041 .