[PyTorch][easy] Fix TODOs in CppFunction constructors #51315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TODOs said to remove this wrapper, and it seems that it can be removed easily. Differential Revision: [D26137147](https://our.internmc.facebook.com/intern/diff/D26137147/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 7638245 (more details on the Dr. CI page):
1 failure not recognized by patterns:
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jan 28, 2021
The TODOs said to remove this wrapper, and it seems that it can be removed easily. Differential Revision: [D26137147](https://our.internmc.facebook.com/intern/diff/D26137147/) [ghstack-poisoned]
swolchok
changed the title
ezyang
approved these changes
Jan 29, 2021
This was referenced Jan 29, 2021
The TODOs said to remove this wrapper, and it seems that it can be removed easily. Differential Revision: [D26137147](https://our.internmc.facebook.com/intern/diff/D26137147/) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/swolchok/102/base #51315 +/- ##
========================================================
+ Coverage 80.82% 80.85% +0.02%
========================================================
Files 1948 1938 -10
Lines 213169 211176 -1993
========================================================
- Hits 172290 170742 -1548
+ Misses 40879 40434 -445 |
The TODOs said to remove this wrapper, and it seems that it can be removed easily. Differential Revision: [D26137147](https://our.internmc.facebook.com/intern/diff/D26137147/) [ghstack-poisoned]
The TODOs said to remove this wrapper, and it seems that it can be removed easily. Differential Revision: [D26137147](https://our.internmc.facebook.com/intern/diff/D26137147/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Feb 9, 2021
Pull Request resolved: #51315 The TODOs said to remove this wrapper, and it seems that it can be removed easily. ghstack-source-id: 121297937 Differential Revision: [D26137147](https://our.internmc.facebook.com/intern/diff/D26137147/)
The TODOs said to remove this wrapper, and it seems that it can be removed easily. Differential Revision: [D26137147](https://our.internmc.facebook.com/intern/diff/D26137147/) [ghstack-poisoned]
|
This pull request has been merged in c931c29. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#51315 The TODOs said to remove this wrapper, and it seems that it can be removed easily. ghstack-source-id: 121363465 Test Plan: CI Reviewed By: ezyang Differential Revision: D26137147 fbshipit-source-id: f1e5971dca071f37400d77cc823214527e4231bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The TODOs said to remove this wrapper, and it seems that it can be removed easily.
Differential Revision: D26137147