KEMBAR78
Use irange in a few places by r-barnes · Pull Request #55325 · pytorch/pytorch · GitHub
Skip to content

Use irange in a few places #55325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use irange in a few places #55325

wants to merge 1 commit into from

Conversation

@r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Apr 5, 2021

Differential Revision: D27573006

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue labels Apr 5, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6e07408 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 07 18:44:55 [E request_callback_no_python.c...quest type 275: Unexpected end of pickler archive. 
Jun 07 18:44:55 frame #9: torch::distributed::rpc::RequestCallbackNoPython::processMessage(torch::distributed::rpc::Message&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0x97 (0x7fbf9e3c4d97 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #10: torch::distributed::rpc::RequestCallback::operator()(torch::distributed::rpc::Message&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0x61 (0x7fbf9e3b8fd1 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #11: <unknown function> + 0x2145e0f (0x7fbfae3aae0f in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_python.so)
Jun 07 18:44:55 frame #12: <unknown function> + 0x2146f85 (0x7fbfae3abf85 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_python.so)
Jun 07 18:44:55 frame #13: c10::ThreadPool::main_loop(unsigned long) + 0x3bc (0x7fbfabbc244c in /opt/conda/lib/python3.8/site-packages/torch/lib/libc10.so)
Jun 07 18:44:55 frame #14: <unknown function> + 0x787aa (0x7fbfabbc27aa in /opt/conda/lib/python3.8/site-packages/torch/lib/libc10.so)
Jun 07 18:44:55 frame #15: <unknown function> + 0xc819d (0x7fbf953ac19d in /opt/conda/lib/libstdc++.so.6)
Jun 07 18:44:55 frame #16: <unknown function> + 0x76db (0x7fbfbd4c26db in /lib/x86_64-linux-gnu/libpthread.so.0)
Jun 07 18:44:55 frame #17: clone + 0x3f (0x7fbfbd1eb71f in /lib/x86_64-linux-gnu/libc.so.6)
Jun 07 18:44:55 
Jun 07 18:44:55 [E request_callback_no_python.cpp:552] Received error while processing request type 275: Unexpected end of pickler archive.
Jun 07 18:44:55 Exception raised from readSlowWithBuffer at /var/lib/jenkins/workspace/torch/csrc/jit/serialization/unpickler.cpp:756 (most recent call first):
Jun 07 18:44:55 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x59 (0x7fbfabbd3ce9 in /opt/conda/lib/python3.8/site-packages/torch/lib/libc10.so)
Jun 07 18:44:55 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, char const*) + 0x161 (0x7fbfabb8b657 in /opt/conda/lib/python3.8/site-packages/torch/lib/libc10.so)
Jun 07 18:44:55 frame #2: <unknown function> + 0x8ba8c03 (0x7fbf9e000c03 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #3: torch::jit::Unpickler::run() + 0x130 (0x7fbf9e00d3a0 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #4: torch::jit::Unpickler::parse_ivalue() + 0x37 (0x7fbf9e00f357 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #5: torch::jit::unpickle(std::function<unsigned long (char*, unsigned long)>, std::function<c10::StrongTypePtr (c10::QualifiedName const&)>, c10::ArrayRef<at::Tensor>) + 0x2b5 (0x7fbf9dfcbfe5 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #6: torch::jit::unpickle(char const*, unsigned long, std::function<c10::StrongTypePtr (c10::QualifiedName const&)>, c10::ArrayRef<at::Tensor>) + 0xf6 (0x7fbf9dfcc136 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #7: torch::distributed::autograd::CleanupAutogradContextReq::fromMessage(torch::distributed::rpc::Message const&) + 0xe1 (0x7fbf9e3a2291 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
Jun 07 18:44:55 frame #8: torch::distributed::rpc::deserializeRequest(torch::distributed::rpc::Message const&) + 0x296 (0x7fbf9e4024c6 in /opt/conda/lib/python3.8/site-packages/torch/lib/libtorch_cpu.so)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27573006

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27573006

@codecov
Copy link

codecov bot commented Apr 8, 2021 •
edited
Loading

Codecov Report

Merging #55325 (a894f43) into master (1d37f41) will increase coverage by 1.05%.
The diff coverage is 0.00%.

❗ Current head a894f43 differs from pull request most recent head b6318c5. Consider uploading reports for the commit b6318c5 to get more accurate results

@@            Coverage Diff             @@
##           master   #55325      +/-   ##
==========================================
+ Coverage   76.36%   77.42%   +1.05%     
==========================================
  Files        2022     1891     -131     
  Lines      202455   187521   -14934     
==========================================
- Hits       154611   145181    -9430     
+ Misses      47844    42340    -5504

pritamdamania87
pritamdamania87 reviewed Apr 9, 2021
View reviewed changes
torch/lib/c10d/ProcessGroupMPI.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to know what is the benefit of using irange instead of regular loops? Is this mostly for readability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've answered more fully via DM. In short: type safety, const safety, and consistency.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27573006

@r-barnes r-barnes force-pushed the export-D27573006 branch from a894f43 to b6318c5 Compare June 2, 2021 16:43
@r-barnes @facebook-github-bot
Use irange in a few places (pytorch#55325)
6e07408 
Summary: Pull Request resolved: pytorch#55325

Test Plan: Sandcastle

Differential Revision: D27573006

fbshipit-source-id: eea0a1a28674f14ac68ecad1c656c72fd8a8fabb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27573006

@r-barnes r-barnes force-pushed the export-D27573006 branch from b6318c5 to 6e07408 Compare June 7, 2021 17:36
@r-barnes r-barnes requested a review from cbalioglu as a code owner June 7, 2021 17:36
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 93140a3.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@r-barnes @deniskokarev
Use irange in a few places (pytorch#55325)
8192fe6 
Summary: Pull Request resolved: pytorch#55325

Test Plan: Sandcastle

Reviewed By: SciPioneer

Differential Revision: D27573006

fbshipit-source-id: 647b5da3901e92c23e95b2fe5e833e9081d72837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD Awaiting requested review from albanD

@H-Huang H-Huang Awaiting requested review from H-Huang

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@mrshenli mrshenli Awaiting requested review from mrshenli

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@soulitzer soulitzer Awaiting requested review from soulitzer

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@cbalioglu cbalioglu Awaiting requested review from cbalioglu

2 more reviewers

@pritamdamania87 pritamdamania87 pritamdamania87 left review comments

@wayi1 wayi1 wayi1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed fb-exported Merged oncall: distributed Add this issue/PR to distributed oncall triage queue oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@r-barnes @facebook-github-bot @wayi1 @pritamdamania87