KEMBAR78
Improve error message when Proxy object is iterated by ansley · Pull Request #58302 · pytorch/pytorch · GitHub
Skip to content

Conversation

@ansley
Copy link

@ansley ansley commented May 14, 2021

Stack from ghstack:

Differential Revision: D28444030

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 14, 2021

💊 CI failures summary and remediations

As of commit 1c7b00f (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ansley pushed a commit that referenced this pull request May 14, 2021
ghstack-source-id: b79c484
Pull Request resolved: #58302
@ansley
Copy link
Author

ansley commented May 14, 2021

@ansley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ansley ansley requested a review from jamesr66a May 14, 2021 16:31
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #58302 (1c7b00f) into gh/ansley/32/base (c711c30) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           gh/ansley/32/base   #58302      +/-   ##
=====================================================
- Coverage              76.46%   76.43%   -0.03%     
=====================================================
  Files                   1992     1992              
  Lines                 199811   199811              
=====================================================
- Hits                  152778   152723      -55     
- Misses                 47033    47088      +55     

@ansley ansley requested a review from jamesr66a May 15, 2021 03:25
ansley pushed a commit that referenced this pull request May 15, 2021
ghstack-source-id: 613eb13
Pull Request resolved: #58302
@ansley
Copy link
Author

ansley commented May 15, 2021

@ansley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ansley merged this pull request in 443ce1e.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary: Pull Request resolved: pytorch#58302

Test Plan: Imported from OSS

Reviewed By: jamesr66a

Differential Revision: D28444030

Pulled By: ansley

fbshipit-source-id: ee29b0f7b2199f8590de4c5945b0d4ce59230ce2
@facebook-github-bot facebook-github-bot deleted the gh/ansley/32/head branch May 21, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants