[Reducer] Remove replica size == 1 checks #58603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer need these checks Differential Revision: [D28549893](https://our.internmc.facebook.com/intern/diff/D28549893/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 8dcb57f (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 19, 2021
zhaojuanmao
approved these changes
May 19, 2021
No longer need these checks Differential Revision: [D28549893](https://our.internmc.facebook.com/intern/diff/D28549893/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
May 19, 2021
Pull Request resolved: #58603 No longer need these checks ghstack-source-id: 129389762 Differential Revision: [D28549893](https://our.internmc.facebook.com/intern/diff/D28549893/)
facebook-github-bot
added
the
oncall: distributed
No longer need these checks Differential Revision: [D28549893](https://our.internmc.facebook.com/intern/diff/D28549893/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
May 20, 2021
Pull Request resolved: #58603 No longer need these checks ghstack-source-id: 129441558 Differential Revision: [D28549893](https://our.internmc.facebook.com/intern/diff/D28549893/)
No longer need these checks Differential Revision: [D28549893](https://our.internmc.facebook.com/intern/diff/D28549893/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
May 20, 2021
Pull Request resolved: #58603 No longer need these checks ghstack-source-id: 129498227 Differential Revision: [D28549893](https://our.internmc.facebook.com/intern/diff/D28549893/)
|
This pull request has been merged in b301558. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
No longer need these checks
Differential Revision: D28549893